Skip to content

Cosmetics video player & lesson #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivan-magda merged 6 commits into from
Feb 16, 2020
Merged

Cosmetics video player & lesson #654

ivan-magda merged 6 commits into from
Feb 16, 2020

Conversation

@ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Feb 16, 2020

YouTrack task: #APPS-2690

Description:

  • Video player
    • Increase horizontal spacing between bottom controls.
    • Hide home indicator when playback controls are hidden.
    • Reset to aspect fill mode only on the transition to portrait.
  • Lesson
    • Bump Tabman from 2.6.3 to 2.8.0.
    • Align step content to safe area layout guides.
    • Align the leading constraint of the CodeInputAccessoryView to a safe area layout guide.

@ivan-magda ivan-magda added this to the 1.113 milestone Feb 16, 2020
@ivan-magda ivan-magda self-assigned this Feb 16, 2020
@ivan-magda ivan-magda merged commit e3a64b9 into dev Feb 16, 2020
@ivan-magda ivan-magda deleted the feature/cosmetics-video-player-lesson branch February 16, 2020 15:40
@ivan-magda ivan-magda mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ivan-magda ivan-magda

Labels

main

Projects

None yet

Milestone

1.113

Development

Successfully merging this pull request may close these issues.

2 participants

@ivan-magda