Skip to content

Send analytics event on content language change #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-magda merged 2 commits into from
Apr 21, 2021
Merged

Send analytics event on content language change #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46fee72
Add analytics event
ivan-magda Apr 21, 2021
c76a2e5
Send events
ivan-magda Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Stepic/Legacy/Analytics/Events/AmplitudeAnalyticsEvents.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,26 @@ extension AnalyticsEvent {
return AmplitudeAnalyticsEvent(name: "Font size selected", parameters: ["size": fontSizeStringValue])
}

// MARK: - Content Language -

static func contentLanguageChanged(
_ contentLanguage: ContentLanguage,
source: ContentLanguageChangeSource
) -> AmplitudeAnalyticsEvent {
AmplitudeAnalyticsEvent(
name: "Content language changed",
parameters: [
"language": contentLanguage.languageString,
"source": source.rawValue
]
)
}

enum ContentLanguageChangeSource: String {
case catalog
case settings
}

// MARK: - CoursePreview -

static func coursePreviewScreenOpened(course: Course, viewSource: CourseViewSource) -> AmplitudeAnalyticsEvent {
Expand Down
3 changes: 2 additions & 1 deletion ...urces/Modules/ExploreSubmodules/ContentLanguageSwitch/ContentLanguageSwitchAssembly.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ final class ContentLanguageSwitchAssembly: Assembly {
let presenter = ContentLanguageSwitchPresenter()
let interactor = ContentLanguageSwitchInteractor(
presenter: presenter,
provider: provider
provider: provider,
analytics: StepikAnalytics.shared
)
let viewController = ContentLanguageSwitchViewController(
interactor: interactor
Expand Down
8 changes: 7 additions & 1 deletion ...ces/Modules/ExploreSubmodules/ContentLanguageSwitch/ContentLanguageSwitchInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,18 @@ final class ContentLanguageSwitchInteractor: ContentLanguageSwitchInteractorProt
private let presenter: ContentLanguageSwitchPresenterProtocol
private let provider: ContentLanguageSwitchProviderProtocol

private let analytics: Analytics

private var currentAvailableContentLanguages: [(UniqueIdentifierType, ContentLanguage)] = []

init(
presenter: ContentLanguageSwitchPresenterProtocol,
provider: ContentLanguageSwitchProviderProtocol
provider: ContentLanguageSwitchProviderProtocol,
analytics: Analytics
) {
self.presenter = presenter
self.provider = provider
self.analytics = analytics
}

func doLanguagesListPresentation(request: ContentLanguageSwitch.LanguagesLoad.Request) {
Expand Down Expand Up @@ -56,6 +60,8 @@ final class ContentLanguageSwitchInteractor: ContentLanguageSwitchInteractorProt
fatalError("Request contains invalid data")
}

self.analytics.send(.contentLanguageChanged(selectedLanguage, source: .catalog))

self.provider.setGlobalContentLanguage(selectedLanguage)
self.presenter.presentLanguageChange(
response: ContentLanguageSwitch.LanguageSelection.Response(
Expand Down
4 changes: 3 additions & 1 deletion Stepic/Sources/Modules/Settings/SettingsInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ final class SettingsInteractor: SettingsInteractorProtocol {
}

func doContentLanguageSettingUpdate(request: Settings.ContentLanguageSettingUpdate.Request) {
self.provider.globalContentLanguage = ContentLanguage(languageString: request.setting.uniqueIdentifier)
let selectedContentLanguage = ContentLanguage(languageString: request.setting.uniqueIdentifier)
self.provider.globalContentLanguage = selectedContentLanguage
self.analytics.send(.contentLanguageChanged(selectedContentLanguage, source: .settings))
}

func doStepFontSizeSettingPresentation(request: Settings.StepFontSizeSettingPresentation.Request) {
Expand Down