fix(form-core): validateAllFields not validating with form level validators

Author: harry-whorlow

packages/form-core/src/FormApi.ts

@@ -1548,18 +1548,21 @@ export class FormApi<
    */
   validateAllFields = async (cause: ValidationCause) => {
     const fieldValidationPromises: Promise<ValidationError[]>[] = [] as any
+
     batch(() => {
       void (Object.values(this.fieldInfo) as FieldInfo<any>[]).forEach(
         (field) => {
           if (!field.instance) return
           const fieldInstance = field.instance
+
           // Validate the field
           fieldValidationPromises.push(
             // Remember, `validate` is either a sync operation or a promise
             Promise.resolve().then(() =>
               fieldInstance.validate(cause, { skipFormValidation: true }),
             ),
           )
+
           // If any fields are not touched
           if (!field.instance.state.meta.isTouched) {
             // Mark them as touched

packages/form-core/tests/FormApi.spec.ts

@@ -1945,7 +1945,79 @@ describe('form api', () => {
     ).toBeUndefined()
   })
 
-  it('should validate all fields consistently', async () => {
+  it('should validate all fields consistently - form level onChange validators', async () => {
+    const form = new FormApi({
+      defaultValues: {
+        firstName: '',
+        lastName: '',
+      },
+      validators: {
+        onChange: ({ value }) => {
+          return {
+            fields: {
+              firstName: value.firstName.length > 0 ? undefined : 'is required',
+              lastName: value.lastName.length > 0 ? undefined : 'is required',
+            },
+          }
+        },
+      },
+    })
+
+    const fieldFirstName = new FieldApi({
+      form,
+      name: 'firstName',
+    })
+    const fieldLastName = new FieldApi({
+      form,
+      name: 'lastName',
+    })
+
+    form.mount()
+    fieldFirstName.mount()
+    fieldLastName.mount()
+
+    await form.validateAllFields('change')
+    expect(fieldFirstName.getMeta().errorMap.onChange).toEqual('is required')
+    expect(fieldLastName.getMeta().errorMap.onChange).toEqual('is required')
+  })
+
+  it('should validate all fields consistently - form level onSubmit validators ', async () => {
+    const form = new FormApi({
+      defaultValues: {
+        firstName: '',
+        lastName: '',
+      },
+      validators: {
+        onSubmit: ({ value }) => {
+          return {
+            fields: {
+              firstName: value.firstName.length > 0 ? undefined : 'is required',
+              lastName: value.lastName.length > 0 ? undefined : 'is required',
+            },
+          }
+        },
+      },
+    })
+
+    const fieldFirstName = new FieldApi({
+      form,
+      name: 'firstName',
+    })
+    const fieldLastName = new FieldApi({
+      form,
+      name: 'lastName',
+    })
+
+    form.mount()
+    fieldFirstName.mount()
+    fieldLastName.mount()
+
+    await form.validateAllFields('submit')
+    expect(fieldFirstName.getMeta().errorMap.onSubmit).toEqual('is required')
+    expect(fieldLastName.getMeta().errorMap.onSubmit).toEqual('is required')
+  })
+
+  it('should validate all fields consistently - field level onChange validators', async () => {
     const form = new FormApi({
       defaultValues: {
         firstName: '',
@@ -1957,18 +2029,38 @@ describe('form api', () => {
       form,
       name: 'firstName',
       validators: {
-        onChange: ({ value }) =>
-          value.length > 0 ? undefined : 'first name is required',
+        onChange: ({ value }) => (value.length > 0 ? undefined : 'is required'),
       },
     })
 
     form.mount()
     field.mount()
 
     await form.validateAllFields('change')
-    expect(field.getMeta().errorMap.onChange).toEqual('first name is required')
-    await form.validateAllFields('change')
-    expect(field.getMeta().errorMap.onChange).toEqual('first name is required')
+    expect(field.getMeta().errorMap.onChange).toEqual('is required')
+  })
+
+  it('should validate all fields consistently - field level onSubmit validators', async () => {
+    const form = new FormApi({
+      defaultValues: {
+        firstName: '',
+        lastName: '',
+      },
+    })
+
+    const field = new FieldApi({
+      form,
+      name: 'firstName',
+      validators: {
+        onSubmit: ({ value }) => (value.length > 0 ? undefined : 'is required'),
+      },
+    })
+
+    form.mount()
+    field.mount()
+
+    await form.validateAllFields('submit')
+    expect(field.getMeta().errorMap.onSubmit).toEqual('is required')
   })
 
   it('should validate a single field consistently if touched', async () => {