Skip to content

Commit 1eda603

Browse files
authored
test: remove first level sleep in tests and use fake timers (#809)
1 parent 1e4254d commit 1eda603

File tree

3 files changed

+21
-15
lines changed

3 files changed

+21
-15
lines changed

packages/valibot-form-adapter/tests/FieldApi.spec.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { describe, expect, it } from 'vitest'
1+
import { describe, expect, it, vi } from 'vitest'
22
import { FieldApi, FormApi } from '@tanstack/form-core'
33
import * as v from 'valibot'
44
import { valibotValidator } from '../src/index'
@@ -61,6 +61,7 @@ describe('valibot field api', () => {
6161
})
6262

6363
it('should run an onChangeAsync with string validation', async () => {
64+
vi.useFakeTimers()
6465
const form = new FormApi({
6566
defaultValues: {
6667
name: '',
@@ -87,14 +88,15 @@ describe('valibot field api', () => {
8788

8889
expect(field.getMeta().errors).toEqual([])
8990
field.setValue('a', { touch: true })
90-
await sleep(10)
91+
await vi.advanceTimersByTimeAsync(10)
9192
expect(field.getMeta().errors).toEqual(['Testing 123'])
9293
field.setValue('asdf', { touch: true })
93-
await sleep(10)
94+
await vi.advanceTimersByTimeAsync(10)
9495
expect(field.getMeta().errors).toEqual([])
9596
})
9697

9798
it('should run an onChangeAsyc fn with valibot validation option enabled', async () => {
99+
vi.useFakeTimers()
98100
const form = new FormApi({
99101
defaultValues: {
100102
name: '',
@@ -118,10 +120,10 @@ describe('valibot field api', () => {
118120

119121
expect(field.getMeta().errors).toEqual([])
120122
field.setValue('a', { touch: true })
121-
await sleep(10)
123+
await vi.advanceTimersByTimeAsync(10)
122124
expect(field.getMeta().errors).toEqual(['Test'])
123125
field.setValue('asdf', { touch: true })
124-
await sleep(10)
126+
await vi.advanceTimersByTimeAsync(10)
125127
expect(field.getMeta().errors).toEqual([])
126128
})
127129

packages/yup-form-adapter/tests/FieldApi.spec.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { describe, expect, it } from 'vitest'
1+
import { describe, expect, it, vi } from 'vitest'
22
import { FieldApi, FormApi } from '@tanstack/form-core'
33
import yup from 'yup'
44
import { yupValidator } from '../src/index'
@@ -58,6 +58,7 @@ describe('yup field api', () => {
5858
})
5959

6060
it('should run an onChangeAsync with z.string validation', async () => {
61+
vi.useFakeTimers()
6162
const form = new FormApi({
6263
defaultValues: {
6364
name: '',
@@ -83,14 +84,15 @@ describe('yup field api', () => {
8384

8485
expect(field.getMeta().errors).toEqual([])
8586
field.setValue('a', { touch: true })
86-
await sleep(10)
87+
await vi.advanceTimersByTimeAsync(10)
8788
expect(field.getMeta().errors).toEqual(['Testing 123'])
8889
field.setValue('asdf', { touch: true })
89-
await sleep(10)
90+
await vi.advanceTimersByTimeAsync(10)
9091
expect(field.getMeta().errors).toEqual([])
9192
})
9293

9394
it('should run an onChangeAsyc fn with zod validation option enabled', async () => {
95+
vi.useFakeTimers()
9496
const form = new FormApi({
9597
defaultValues: {
9698
name: '',
@@ -114,10 +116,10 @@ describe('yup field api', () => {
114116

115117
expect(field.getMeta().errors).toEqual([])
116118
field.setValue('a', { touch: true })
117-
await sleep(10)
119+
await vi.advanceTimersByTimeAsync(10)
118120
expect(field.getMeta().errors).toEqual(['Test'])
119121
field.setValue('asdf', { touch: true })
120-
await sleep(10)
122+
await vi.advanceTimersByTimeAsync(10)
121123
expect(field.getMeta().errors).toEqual([])
122124
})
123125

packages/zod-form-adapter/tests/FieldApi.spec.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { describe, expect, it } from 'vitest'
1+
import { describe, expect, it, vi } from 'vitest'
22

33
import { FieldApi, FormApi } from '@tanstack/form-core'
44
import { z } from 'zod'
@@ -59,6 +59,7 @@ describe('zod field api', () => {
5959
})
6060

6161
it('should run an onChangeAsync with z.string validation', async () => {
62+
vi.useFakeTimers()
6263
const form = new FormApi({
6364
defaultValues: {
6465
name: '',
@@ -87,14 +88,15 @@ describe('zod field api', () => {
8788

8889
expect(field.getMeta().errors).toEqual([])
8990
field.setValue('a', { touch: true })
90-
await sleep(10)
91+
await vi.advanceTimersByTimeAsync(10)
9192
expect(field.getMeta().errors).toEqual(['Testing 123'])
9293
field.setValue('asdf', { touch: true })
93-
await sleep(10)
94+
await vi.advanceTimersByTimeAsync(10)
9495
expect(field.getMeta().errors).toEqual([])
9596
})
9697

9798
it('should run an onChangeAsyc fn with zod validation option enabled', async () => {
99+
vi.useFakeTimers()
98100
const form = new FormApi({
99101
defaultValues: {
100102
name: '',
@@ -118,10 +120,10 @@ describe('zod field api', () => {
118120

119121
expect(field.getMeta().errors).toEqual([])
120122
field.setValue('a', { touch: true })
121-
await sleep(10)
123+
await vi.advanceTimersByTimeAsync(10)
122124
expect(field.getMeta().errors).toEqual(['Test'])
123125
field.setValue('asdf', { touch: true })
124-
await sleep(10)
126+
await vi.advanceTimersByTimeAsync(10)
125127
expect(field.getMeta().errors).toEqual([])
126128
})
127129

0 commit comments

Comments
 (0)