Skip to content

Commit 11e0860

Browse files
committed
fix: force context release when disposing renderers
1 parent 67b08df commit 11e0860

File tree

8 files changed

+8
-3
lines changed

8 files changed

+8
-3
lines changed

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@thatopen/components",
33
"description": "Collection of core functionalities to author BIM apps.",
4-
"version": "2.1.23",
4+
"version": "2.1.24",
55
"author": "That Open Company",
66
"contributors": [
77
"Antonio Gonzalez Viegas (https://github.com/agviegas)",

packages/core/src/core/Components/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export class Components implements Disposable {
1414
/**
1515
* The version of the @thatopen/components library.
1616
*/
17-
static readonly release = "2.1.23";
17+
static readonly release = "2.1.24";
1818

1919
/** {@link Disposable.onDisposed} */
2020
readonly onDisposed = new Event<void>();

packages/core/src/core/Cullers/src/culler-renderer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ export class CullerRenderer {
147147
}
148148
this.onViewUpdated.reset();
149149
this.worker.terminate();
150+
this.renderer.forceContextLoss();
150151
this.renderer.dispose();
151152
this.renderTarget.dispose();
152153
(this._buffer as any) = null;

packages/core/src/core/MiniMap/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ export class MiniMap implements Resizeable, Updateable, Disposable {
139139
this.onAfterUpdate.reset();
140140
this.onResize.reset();
141141
this.overrideMaterial.dispose();
142+
this.renderer.forceContextLoss();
142143
this.renderer.dispose();
143144
this.onDisposed.trigger();
144145
this.onDisposed.reset();

packages/core/src/core/ShadowedScene/src/distance-renderer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ void main() {
181181
this.enabled = false;
182182
this.onDistanceComputed.reset();
183183
this.worker.terminate();
184+
this.renderer.forceContextLoss();
184185
this.renderer.dispose();
185186
this.tempRT.dispose();
186187
this.resultRT.dispose();

packages/core/src/core/Worlds/src/simple-renderer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export class SimpleRenderer extends BaseRenderer {
9090
this.enabled = false;
9191
this.setupEvents(false);
9292
this.three.domElement.remove();
93+
this.three.forceContextLoss();
9394
this.three.dispose();
9495
// this._renderer2D.domElement.remove();
9596
this.onResize.reset();

packages/front/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@thatopen/components-front",
33
"description": "Collection of frontend tools to author BIM apps.",
4-
"version": "2.1.25",
4+
"version": "2.1.26",
55
"author": "That Open Company",
66
"contributors": [
77
"Antonio Gonzalez Viegas (https://github.com/agviegas)",

packages/front/src/core/PostproductionRenderer/src/postproduction.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ export class Postproduction {
161161
* It releases the memory occupied by the render target, depth texture, custom effects pass, gamma pass, and N8AO pass.
162162
*/
163163
dispose() {
164+
this.composer.dispose();
164165
this._renderTarget.dispose();
165166
this._depthTexture?.dispose();
166167
this._customEffects?.dispose();

0 commit comments

Comments
 (0)