Skip to content

Commit 3048618

Browse files
committed
fix(core): add guard when getting all properties
1 parent 1570899 commit 3048618

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@thatopen/components",
33
"description": "Collection of core functionalities to author BIM apps.",
4-
"version": "2.3.0-alpha.2",
4+
"version": "2.3.0-alpha.3",
55
"author": "That Open Company",
66
"contributors": [
77
"Antonio Gonzalez Viegas (https://github.com/agviegas)",

packages/core/src/ifc/IfcJsonExporter/index.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,14 @@ export class IfcJsonExporter extends Component {
6868

6969
// const allIDs = this._webIfc.GetAllLines(0);
7070
for (const id of ids) {
71-
const property = webIfc.GetLine(0, id, recursive, indirect);
72-
properties[property.expressID] = property;
71+
try {
72+
const property = webIfc.GetLine(0, id, recursive, indirect);
73+
properties[property.expressID] = property;
74+
} catch (e) {
75+
console.log(
76+
`Could not get property ${id}, with recursive ${recursive} and indirect ${indirect}.`,
77+
);
78+
}
7379
}
7480
}
7581

packages/front/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@thatopen/components-front",
33
"description": "Collection of frontend tools to author BIM apps.",
4-
"version": "2.3.0-alpha.4",
4+
"version": "2.3.0-alpha.5",
55
"author": "That Open Company",
66
"contributors": [
77
"Antonio Gonzalez Viegas (https://github.com/agviegas)",
@@ -38,7 +38,7 @@
3838
"web-ifc": "0.0.57"
3939
},
4040
"devDependencies": {
41-
"@thatopen/fragments": "2.3.0-alpha.1",
41+
"@thatopen/fragments": ">=2.3.0-alpha",
4242
"@thatopen/ui": "~2.2.0",
4343
"@thatopen/ui-obc": "~2.2.0",
4444
"@types/earcut": "^2.1.4",
@@ -47,7 +47,7 @@
4747
"web-ifc": "0.0.57"
4848
},
4949
"dependencies": {
50-
"@thatopen/components": "2.3.0-alpha.1",
50+
"@thatopen/components": ">=2.3.0-alpha",
5151
"camera-controls": "2.7.3",
5252
"dexie": "^4.0.4",
5353
"earcut": "^2.2.4",

0 commit comments

Comments
 (0)