Skip to content

Commit ed779b4

Browse files
committed
fix(core): IfcPropertiesManager.setData properly assigns the entity in the model properties
1 parent d639966 commit ed779b4

File tree

1 file changed

+6
-6
lines changed
  • packages/core/src/ifc/IfcPropertiesManager

1 file changed

+6
-6
lines changed

packages/core/src/ifc/IfcPropertiesManager/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,9 @@ export class IfcPropertiesManager extends Component implements Disposable {
180180
for (const data of dataToSave) {
181181
const { expressID } = data;
182182
if (!expressID || expressID === -1) {
183-
data.expressID = this.increaseMaxID(model);
183+
data.expressID = this.getNewExpressID(model);
184184
}
185-
await model.setProperties(expressID, data);
185+
await model.setProperties(data.expressID, data);
186186
this.registerChange(model, expressID);
187187
}
188188
}
@@ -216,7 +216,7 @@ export class IfcPropertiesManager extends Component implements Disposable {
216216
psetDescription,
217217
[],
218218
);
219-
pset.expressID = this.increaseMaxID(model);
219+
pset.expressID = this.getNewExpressID(model);
220220

221221
// Create the Pset relation
222222
const relGlobalId = this.newGUID(model);
@@ -228,7 +228,7 @@ export class IfcPropertiesManager extends Component implements Disposable {
228228
[],
229229
new WEBIFC.Handle(pset.expressID),
230230
);
231-
rel.expressID = this.increaseMaxID(model);
231+
rel.expressID = this.getNewExpressID(model);
232232

233233
await this.setData(model, pset, rel);
234234

@@ -542,7 +542,7 @@ export class IfcPropertiesManager extends Component implements Disposable {
542542
return event;
543543
}
544544

545-
private increaseMaxID(model: FragmentsGroup) {
545+
private getNewExpressID(model: FragmentsGroup) {
546546
model.ifcMetadata.maxExpressID++;
547547
return model.ifcMetadata.maxExpressID;
548548
}
@@ -591,7 +591,7 @@ export class IfcPropertiesManager extends Component implements Disposable {
591591
propValue,
592592
null,
593593
);
594-
prop.expressID = this.increaseMaxID(model);
594+
prop.expressID = this.getNewExpressID(model);
595595
await this.setData(model, prop);
596596
return prop;
597597
}

0 commit comments

Comments
 (0)