Rename Register to Service; re-export as Register for backwards…
#1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 79.60% 79.33% -0.27%
==========================================
Files 7 11 +4
Lines 711 755 +44
Branches 158 157 -1
==========================================
+ Hits 566 599 +33
- Misses 89 101 +12
+ Partials 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
blakeembrey
approved these changes
Dec 2, 2020
src/index.ts
Outdated
| function registerExtension ( | ||
| ext: string, | ||
| register: Register, | ||
| register: Service, |
Member
There was a problem hiding this comment.
Should we rename this variable too?
Collaborator
Author
There was a problem hiding this comment.
Yeah, good catch.
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation here: #1121 (comment)
create()will create aService.register()will create and register it into the node runtime. But the object itself is not really aRegister(noun), it's aServicewhich handles compilation.Other names could be
Compiler,TsNodeCompiler, orCompiler?