fix(ui5-button): announce the text node properly #12077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🎉 This PR is included in version v2.14.0-rc.1 🎉 The release is available on v2.14.0-rc.1 Your semantic-release bot 📦🚀 |
nnaydenow
pushed a commit
that referenced
this pull request
Aug 18, 2025
fix(ui5-button): announce the text node properly Issue: - The inner text of the button wasn't announced when the design property was set. Solution: - The inner text is now part of the aria-label attribute alongside the design type text. Fixes: #12037
1 task
ilhan007
pushed a commit
that referenced
this pull request
Dec 8, 2025
fix(ui5-button): announce the text node properly Issue: - The inner text of the button wasn't announced when the design property was set. Solution: - The inner text is now part of the aria-label attribute alongside the design type text. Fixes: #12037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Solution:
Fixes: #12037