move composer update into dockerfile

Author: simonLeary42

.github/workflows/functional.yml

@@ -14,9 +14,6 @@ jobs:
       uses: hoverkraft-tech/[email protected]
       with:
         compose-file: "./tools/docker-dev/docker-compose.yml"
-    - name: Execute tests in the running services
-      run: |
-        docker compose exec -w '/var/www/unity-web-portal' web composer update
     - name: Execute tests in the running services
       run: |
         docker compose exec -w '/var/www/unity-web-portal' web ./vendor/bin/phpunit --testsuite=functional

tools/docker-dev/web/Dockerfile

@@ -30,4 +30,5 @@ RUN sed -i '/memory_limit/c\memory_limit = -1' /etc/php/8.3/apache2/php.ini
 # Start apache2 server
 EXPOSE 80
 
-CMD ["bash", "-c", "pushd /var/www/unity-web-portal/workers >/dev/null && echo 'updating LDAP cache...' && php ./update-ldap-cache.php && popd >/dev/null && apache2ctl -D FOREGROUND"]
+# normally composer deps are bind mounted, have to install when running in github action
+CMD ["bash", "-c", "(if [ ! -f vendor/autoload.php ]; then composer update; fi) && pushd /var/www/unity-web-portal/workers >/dev/null && echo 'updating LDAP cache...' && php ./update-ldap-cache.php && popd >/dev/null && apache2ctl -D FOREGROUND"]