From 5870d275d69aef036d452a4f051f247d46130854 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 14:05:40 -0400
Subject: [PATCH 01/11] add check for special characters in login shell

---
 resources/lib/UnityUser.php |  4 ++-
 webroot/panel/account.php   | 52 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/resources/lib/UnityUser.php b/resources/lib/UnityUser.php
index ccf7fb9e..6fe2548d 100644
--- a/resources/lib/UnityUser.php
+++ b/resources/lib/UnityUser.php
@@ -446,8 +446,10 @@ public function getSSHKeys($ignorecache = false)
      */
     public function setLoginShell($shell, $operator = null, $send_mail = true)
     {
-        // FIXME throw error if shell is not ascii
         // ldap schema syntax is "IA5 String (1.3.6.1.4.1.1466.115.121.1.26)"
+        if (!mb_check_encoding($shell, 'ASCII')) {
+            throw new Exception("non ascii characters are not allowed in a login shell!");
+        }
         $ldapUser = $this->getLDAPUser();
         if ($ldapUser->exists()) {
             $ldapUser->setAttribute("loginshell", $shell);
diff --git a/webroot/panel/account.php b/webroot/panel/account.php
index 9e6272da..cd843393 100644
--- a/webroot/panel/account.php
+++ b/webroot/panel/account.php
@@ -257,7 +257,6 @@
 
 <hr>
 
-
 <script>
     const sitePrefix = '<?php echo $CONFIG["site"]["prefix"]; ?>';
     const ldapLoginShell = '<?php echo $USER->getLoginShell(); ?>';
@@ -289,6 +288,57 @@ function showOrHideCustomLoginBox() {
     $("#loginSelector").change(showOrHideCustomLoginBox);
     showOrHideCustomLoginBox();
 
+    function getNewLoginShell() {
+        var loginSelectorVal = $("#loginSelector").val();
+        if (loginSelectorVal != "Custom") {
+            return loginSelectorVal;
+        }
+        return $("#customLoginBox").val();
+    }
+
+    function isLoginShellValid(x) {
+        if (x.trim().length === 0) {
+            return false;
+        }
+        // only ascii characters allowed
+        if (!(/^[\x00-\x7F]*$/.test(x))) {
+            return false;
+        }
+        return true;
+    }
+
+    function enableOrDisableCustomLoginBoxHighlight() {
+        if (
+            ($("#customLoginSelectorOption").prop("selected") == true) &&
+            !isLoginShellValid($("#customLoginBox").val())
+        ) {
+            $("#customLoginBox").css("box-shadow", "0 0 0 0.3rem rgba(220, 53, 69, 0.25)");
+        } else {
+            $("#customLoginBox").css("box-shadow", "none");
+        }
+    }
+    $("#customLoginBox").on("input", enableOrDisableCustomLoginBoxHighlight);
+    $("#loginSelector").change(enableOrDisableCustomLoginBoxHighlight);
+    enableOrDisableCustomLoginBoxHighlight();
+
+    function enableOrDisableSubmitLoginShell() {
+        var newLoginShell = getNewLoginShell();
+        if (!isLoginShellValid(newLoginShell)) {
+            $("#submitLoginShell").prop("disabled", true);
+            $("#submitLoginShell").prop("title", "Invalid Login Shell");
+            return;
+        }
+        if (newLoginShell == ldapLoginShell) {
+            $("#submitLoginShell").prop("disabled", true);
+            $("#submitLoginShell").prop("title", "Login Shell Unchanged");
+            return;
+        }
+        $("#submitLoginShell").prop("disabled", false);
+        $("#submitLoginShell").prop("title", "Submit Login Shell");
+    }
+    $("#customLoginBox").on("input", enableOrDisableSubmitLoginShell);
+    $("#loginSelector").change(enableOrDisableSubmitLoginShell);
+    enableOrDisableSubmitLoginShell()
 </script>
 
 <style>

From 1ed136d2a9bf197d9db2282757fcf45fafd603df Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 14:45:30 -0400
Subject: [PATCH 02/11] display invalid reason in <p> like the rest of the page

---
 webroot/panel/account.php | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/webroot/panel/account.php b/webroot/panel/account.php
index cd843393..c0cc08a2 100644
--- a/webroot/panel/account.php
+++ b/webroot/panel/account.php
@@ -225,6 +225,7 @@
 ?>
 <br>
 <input id='submitLoginShell' type='submit' value='Set Login Shell' />
+<label id='labelSubmitLoginShell'> <!-- value set by JS --> </label>
 </form>
 <hr>
 
@@ -297,14 +298,17 @@ function getNewLoginShell() {
     }
 
     function isLoginShellValid(x) {
-        if (x.trim().length === 0) {
-            return false;
+        if (/^\s|\s$/.test(x)) {
+            return [false, "must not have leading or trailing whitespace"];
+        }
+        if (x.length === 0) {
+            return [false, "must not be empty"];
         }
         // only ascii characters allowed
         if (!(/^[\x00-\x7F]*$/.test(x))) {
-            return false;
+            return [false, "must only contain ASCII characters"];
         }
-        return true;
+        return [true, ""];
     }
 
     function enableOrDisableCustomLoginBoxHighlight() {
@@ -323,18 +327,21 @@ function enableOrDisableCustomLoginBoxHighlight() {
 
     function enableOrDisableSubmitLoginShell() {
         var newLoginShell = getNewLoginShell();
-        if (!isLoginShellValid(newLoginShell)) {
+        isValidArr = isLoginShellValid(newLoginShell);
+        isValid = isValidArr[0];
+        isValidReason = isValidArr[1];
+        if (!isValid) {
             $("#submitLoginShell").prop("disabled", true);
-            $("#submitLoginShell").prop("title", "Invalid Login Shell");
+            $("#labelSubmitLoginShell").text(`(invalid login shell: ${isValidReason})`);
             return;
         }
         if (newLoginShell == ldapLoginShell) {
             $("#submitLoginShell").prop("disabled", true);
-            $("#submitLoginShell").prop("title", "Login Shell Unchanged");
+            $("#labelSubmitLoginShell").text("(no change)");
             return;
         }
         $("#submitLoginShell").prop("disabled", false);
-        $("#submitLoginShell").prop("title", "Submit Login Shell");
+        $("#labelSubmitLoginShell").text("");
     }
     $("#customLoginBox").on("input", enableOrDisableSubmitLoginShell);
     $("#loginSelector").change(enableOrDisableSubmitLoginShell);

From 74a73250fd8abe0ada1809d5a1500a8a5e8fdfcb Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 14:55:43 -0400
Subject: [PATCH 03/11] remove comment

---
 webroot/panel/account.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/webroot/panel/account.php b/webroot/panel/account.php
index c0cc08a2..a1ba6833 100644
--- a/webroot/panel/account.php
+++ b/webroot/panel/account.php
@@ -304,7 +304,6 @@ function isLoginShellValid(x) {
         if (x.length === 0) {
             return [false, "must not be empty"];
         }
-        // only ascii characters allowed
         if (!(/^[\x00-\x7F]*$/.test(x))) {
             return [false, "must only contain ASCII characters"];
         }

From 79759294c87cb3cbfc2826ddadbfb8b9bd683049 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:01:00 -0400
Subject: [PATCH 04/11] update unityuser to do same checks on login shell as
 frontend does

---
 resources/lib/UnityUser.php           | 3 +++
 test/functional/LoginShellSetTest.php | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/resources/lib/UnityUser.php b/resources/lib/UnityUser.php
index 6fe2548d..d1c556ea 100644
--- a/resources/lib/UnityUser.php
+++ b/resources/lib/UnityUser.php
@@ -450,6 +450,9 @@ public function setLoginShell($shell, $operator = null, $send_mail = true)
         if (!mb_check_encoding($shell, 'ASCII')) {
             throw new Exception("non ascii characters are not allowed in a login shell!");
         }
+        if ($shell != trim($shell)) {
+            throw new Exception("leading/trailing whitespace is not allowed in a login shell!");
+        }
         $ldapUser = $this->getLDAPUser();
         if ($ldapUser->exists()) {
             $ldapUser->setAttribute("loginshell", $shell);
diff --git a/test/functional/LoginShellSetTest.php b/test/functional/LoginShellSetTest.php
index 86ffbaea..174384f3 100644
--- a/test/functional/LoginShellSetTest.php
+++ b/test/functional/LoginShellSetTest.php
@@ -36,6 +36,9 @@ public function testSetLoginShellCustom(string $shell): void
         if (!mb_check_encoding($shell, 'ASCII')) {
             $this->expectException("Exception");
         }
+        if ($shell != trim($shell)) {
+            $this->expectException("Exception");
+        }
         // FIXME shell is not validated
         post(
             __DIR__ . "/../../webroot/panel/account.php",

From c0ae6971654d02655a2bd9ceefcb1b3a7cf9ee6f Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:06:45 -0400
Subject: [PATCH 05/11] update CONTRIBUTING.md

---
 CONTRIBUTING.md | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3ae230e6..efb4280d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -10,6 +10,11 @@ When submitting pull requests, the pull request should be made to the version yo
 
 This code base is currently using PHP version 7.4. All files are required to be linted with PSR-12 standard. This repository will automatically check PRs for linting compliance.
 
+Whenever frontend JS limits the possible values of a user input, PHP must do the same!
+There's nothing stopping a user from making custom HTTP POST requests.
+This can be done in `webroot/panel/*.php` while parsing headers, or preferrably in `resources/lib/*.php`.
+For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters.
+
 ## Development Environment
 
 ### Setting up your Environment
@@ -51,4 +56,4 @@ The following users are available for testing:
 
 ### Changes to Dev Environment
 
-Should the default schema of the web portal change, the `ldap/bootstrap.ldif` and `sql/bootstrap.sql` must be updated for the LDAP server and the MySQL server, respectively.
\ No newline at end of file
+Should the default schema of the web portal change, the `ldap/bootstrap.ldif` and `sql/bootstrap.sql` must be updated for the LDAP server and the MySQL server, respectively.

From 6592987582f56377cdcd36d4a8f2d8efb14a9fa4 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:07:54 -0400
Subject: [PATCH 06/11] add check for empty shell

---
 resources/lib/UnityUser.php           | 3 +++
 test/functional/LoginShellSetTest.php | 9 +++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/resources/lib/UnityUser.php b/resources/lib/UnityUser.php
index d1c556ea..a2e839da 100644
--- a/resources/lib/UnityUser.php
+++ b/resources/lib/UnityUser.php
@@ -453,6 +453,9 @@ public function setLoginShell($shell, $operator = null, $send_mail = true)
         if ($shell != trim($shell)) {
             throw new Exception("leading/trailing whitespace is not allowed in a login shell!");
         }
+        if (empty($shell)) {
+            throw new Exception("login shell must not be empty!");
+        }
         $ldapUser = $this->getLDAPUser();
         if ($ldapUser->exists()) {
             $ldapUser->setAttribute("loginshell", $shell);
diff --git a/test/functional/LoginShellSetTest.php b/test/functional/LoginShellSetTest.php
index 174384f3..e0b5950b 100644
--- a/test/functional/LoginShellSetTest.php
+++ b/test/functional/LoginShellSetTest.php
@@ -33,10 +33,11 @@ public function testSetLoginShellCustom(string $shell): void
     {
         global $USER;
         // FIXME add check to avoid warning from ldap_modify
-        if (!mb_check_encoding($shell, 'ASCII')) {
-            $this->expectException("Exception");
-        }
-        if ($shell != trim($shell)) {
+        if (
+            (!mb_check_encoding($shell, 'ASCII')) ||
+            ($shell != trim($shell)) ||
+            (empty($shell))
+        ) {
             $this->expectException("Exception");
         }
         // FIXME shell is not validated

From cb1cd8beb0d5966d1e7d057b0b22ad698935ebde Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:16:35 -0400
Subject: [PATCH 07/11] update tests

---
 test/functional/LoginShellSetTest.php | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/test/functional/LoginShellSetTest.php b/test/functional/LoginShellSetTest.php
index e0b5950b..e49adb5f 100644
--- a/test/functional/LoginShellSetTest.php
+++ b/test/functional/LoginShellSetTest.php
@@ -28,19 +28,22 @@ public static function getShells()
         // phpcs:enable
     }
 
+    private function isShellValid(string $shell)
+    {
+        return (
+            (mb_check_encoding($shell, 'ASCII')) &&
+            ($shell == trim($shell)) &&
+            (!empty($shell))
+        );
+    }
+
     #[DataProvider("getShells")]
     public function testSetLoginShellCustom(string $shell): void
     {
         global $USER;
-        // FIXME add check to avoid warning from ldap_modify
-        if (
-            (!mb_check_encoding($shell, 'ASCII')) ||
-            ($shell != trim($shell)) ||
-            (empty($shell))
-        ) {
-            $this->expectException("Exception");
+        if (!$this->isShellValid($shell)) {
+            $this->expectException(Exception::class);
         }
-        // FIXME shell is not validated
         post(
             __DIR__ . "/../../webroot/panel/account.php",
             ["form_type" => "loginshell", "shellSelect" => "Custom", "shell" => $shell]
@@ -52,11 +55,9 @@ public function testSetLoginShellCustom(string $shell): void
     public function testSetLoginShellSelect(string $shell): void
     {
         global $USER;
-        // FIXME add check to avoid warning from ldap_modify
-        if (!mb_check_encoding($shell, 'ASCII')) {
+        if (!$this->isShellValid($shell)) {
             $this->expectException("Exception");
         }
-        // FIXME shell is not validated
         post(
             __DIR__ . "/../../webroot/panel/account.php",
             ["form_type" => "loginshell", "shellSelect" => $shell]

From d189ab642a206350eeb1f5c48bc22469c2d955a3 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:18:06 -0400
Subject: [PATCH 08/11] update CONTRIBUTING.md

---
 CONTRIBUTING.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index efb4280d..b5ad90db 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -10,10 +10,10 @@ When submitting pull requests, the pull request should be made to the version yo
 
 This code base is currently using PHP version 7.4. All files are required to be linted with PSR-12 standard. This repository will automatically check PRs for linting compliance.
 
-Whenever frontend JS limits the possible values of a user input, PHP must do the same!
+Whenever frontend JS limits the possible values of a user input, PHP must also do the same, and tests must be written.
 There's nothing stopping a user from making custom HTTP POST requests.
 This can be done in `webroot/panel/*.php` while parsing headers, or preferrably in `resources/lib/*.php`.
-For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters.
+For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters, and this is tested in `test/functional/LoginShellSetTest.php`.
 
 ## Development Environment
 

From b45d48b6a0238a8484cff0d3563261de9e6c9065 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:31:51 -0400
Subject: [PATCH 09/11] remove custom login shell

---
 defaults/config.ini.default |  1 +
 webroot/panel/account.php   | 87 ++-----------------------------------
 2 files changed, 5 insertions(+), 83 deletions(-)

diff --git a/defaults/config.ini.default b/defaults/config.ini.default
index 8c56b24d..94e4075b 100644
--- a/defaults/config.ini.default
+++ b/defaults/config.ini.default
@@ -75,6 +75,7 @@ title[] = "Test Medium Footer"
 [loginshell]  ; Login shells that show up as options in the account settings page
 shell[] = "/bin/bash"
 shell[] = "/bin/zsh"
+shell[] = "/bin/tcsh"
 
 [menuitems]  ; menu items, add a label and link for each
 labels[] = "Global Menuitem 1"
diff --git a/webroot/panel/account.php b/webroot/panel/account.php
index a1ba6833..e4bcd7e0 100644
--- a/webroot/panel/account.php
+++ b/webroot/panel/account.php
@@ -69,11 +69,7 @@
             $USER->setSSHKeys($keys, $OPERATOR);  // Update user keys
             break;
         case "loginshell":
-            if ($_POST["shellSelect"] == "Custom") {
-                $USER->setLoginShell($_POST["shell"], $OPERATOR);
-            } else {
-                $USER->setLoginShell($_POST["shellSelect"], $OPERATOR);
-            }
+            $USER->setLoginShell($_POST["shellSelect"], $OPERATOR);
             break;
         case "pi_request":
             if (!$USER->isPI()) {
@@ -210,19 +206,8 @@
 foreach ($CONFIG["loginshell"]["shell"] as $shell) {
     echo "<option>$shell</option>";
 }
-echo "<option id='customLoginSelectorOption'>Custom</option>";
 ?>
 </select>
-<?php
-echo "
-    <input
-        id='customLoginBox'
-        type='text'
-        placeholder='Enter login shell path (ie. /bin/bash)'
-        name='shell'
-    />
-";
-?>
 <br>
 <input id='submitLoginShell' type='submit' value='Set Login Shell' />
 <label id='labelSubmitLoginShell'> <!-- value set by JS --> </label>
@@ -266,83 +251,19 @@
         openModal("Add New Key", `${sitePrefix}/panel/modal/new_key.php`);
     });
 
-    var defaultShellSelected = false;
     $("#loginSelector option").each(function(i, e) {
         if ($(this).val() == ldapLoginShell) {
             $(this).prop("selected", true);
-            defaultShellSelected = true;
         }
     });
-    if (!defaultShellSelected) {
-        $("#customLoginBox").val(ldapLoginShell);
-        $("#customLoginSelectorOption").prop("selected", true);
-    }
-
-    function showOrHideCustomLoginBox() {
-        var customBox = $("#customLoginBox");
-        if($("#loginSelector").val() == "Custom") {
-            customBox.show();
-        } else {
-            customBox.hide();
-        }
-    }
-    $("#loginSelector").change(showOrHideCustomLoginBox);
-    showOrHideCustomLoginBox();
-
-    function getNewLoginShell() {
-        var loginSelectorVal = $("#loginSelector").val();
-        if (loginSelectorVal != "Custom") {
-            return loginSelectorVal;
-        }
-        return $("#customLoginBox").val();
-    }
-
-    function isLoginShellValid(x) {
-        if (/^\s|\s$/.test(x)) {
-            return [false, "must not have leading or trailing whitespace"];
-        }
-        if (x.length === 0) {
-            return [false, "must not be empty"];
-        }
-        if (!(/^[\x00-\x7F]*$/.test(x))) {
-            return [false, "must only contain ASCII characters"];
-        }
-        return [true, ""];
-    }
-
-    function enableOrDisableCustomLoginBoxHighlight() {
-        if (
-            ($("#customLoginSelectorOption").prop("selected") == true) &&
-            !isLoginShellValid($("#customLoginBox").val())
-        ) {
-            $("#customLoginBox").css("box-shadow", "0 0 0 0.3rem rgba(220, 53, 69, 0.25)");
-        } else {
-            $("#customLoginBox").css("box-shadow", "none");
-        }
-    }
-    $("#customLoginBox").on("input", enableOrDisableCustomLoginBoxHighlight);
-    $("#loginSelector").change(enableOrDisableCustomLoginBoxHighlight);
-    enableOrDisableCustomLoginBoxHighlight();
 
     function enableOrDisableSubmitLoginShell() {
-        var newLoginShell = getNewLoginShell();
-        isValidArr = isLoginShellValid(newLoginShell);
-        isValid = isValidArr[0];
-        isValidReason = isValidArr[1];
-        if (!isValid) {
+        if ($("#loginSelector").val() == ldapLoginShell) {
             $("#submitLoginShell").prop("disabled", true);
-            $("#labelSubmitLoginShell").text(`(invalid login shell: ${isValidReason})`);
-            return;
-        }
-        if (newLoginShell == ldapLoginShell) {
-            $("#submitLoginShell").prop("disabled", true);
-            $("#labelSubmitLoginShell").text("(no change)");
-            return;
+        } else {
+            $("#submitLoginShell").prop("disabled", false);
         }
-        $("#submitLoginShell").prop("disabled", false);
-        $("#labelSubmitLoginShell").text("");
     }
-    $("#customLoginBox").on("input", enableOrDisableSubmitLoginShell);
     $("#loginSelector").change(enableOrDisableSubmitLoginShell);
     enableOrDisableSubmitLoginShell()
 </script>

From 9fea3abce00933ea1c3709d8692cb04368eee7b1 Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:32:37 -0400
Subject: [PATCH 10/11] remove note from contrib

---
 CONTRIBUTING.md | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b5ad90db..af35252b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -10,11 +10,6 @@ When submitting pull requests, the pull request should be made to the version yo
 
 This code base is currently using PHP version 7.4. All files are required to be linted with PSR-12 standard. This repository will automatically check PRs for linting compliance.
 
-Whenever frontend JS limits the possible values of a user input, PHP must also do the same, and tests must be written.
-There's nothing stopping a user from making custom HTTP POST requests.
-This can be done in `webroot/panel/*.php` while parsing headers, or preferrably in `resources/lib/*.php`.
-For example, both frontend JS and in the `UnityUser` class make sure that a login shell contains only ASCII characters, and this is tested in `test/functional/LoginShellSetTest.php`.
-
 ## Development Environment
 
 ### Setting up your Environment

From 06197734b430e3a26af6f1d34f8db6607e5f052a Mon Sep 17 00:00:00 2001
From: Simon Leary <simon.leary42@proton.me>
Date: Thu, 24 Apr 2025 15:36:20 -0400
Subject: [PATCH 11/11] update test

---
 test/functional/LoginShellSetTest.php | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/test/functional/LoginShellSetTest.php b/test/functional/LoginShellSetTest.php
index e49adb5f..2d41f918 100644
--- a/test/functional/LoginShellSetTest.php
+++ b/test/functional/LoginShellSetTest.php
@@ -38,21 +38,7 @@ private function isShellValid(string $shell)
     }
 
     #[DataProvider("getShells")]
-    public function testSetLoginShellCustom(string $shell): void
-    {
-        global $USER;
-        if (!$this->isShellValid($shell)) {
-            $this->expectException(Exception::class);
-        }
-        post(
-            __DIR__ . "/../../webroot/panel/account.php",
-            ["form_type" => "loginshell", "shellSelect" => "Custom", "shell" => $shell]
-        );
-        $this->assertEquals($shell, $USER->getLoginShell());
-    }
-
-    #[DataProvider("getShells")]
-    public function testSetLoginShellSelect(string $shell): void
+    public function testSetLoginShell(string $shell): void
     {
         global $USER;
         if (!$this->isShellValid($shell)) {