Skip to content

feat: add example app#9

Merged
renancaraujo merged 4 commits intomainfrom
feat/add-example
Nov 15, 2022
Merged

feat: add example app#9
renancaraujo merged 4 commits intomainfrom
feat/add-example

Conversation

@renancaraujo
Copy link
Copy Markdown
Contributor

@renancaraujo renancaraujo commented Nov 11, 2022

Status

READY

Description

Add a CLI package as an example with most common use cases for command completion

ref: #2

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo force-pushed the feat/add-example branch 4 times, most recently from 6215475 to 7a3a16d Compare November 14, 2022 13:42
@renancaraujo renancaraujo marked this pull request as ready for review November 14, 2022 13:43
example/LICENSE Outdated
@@ -0,0 +1,21 @@
MIT License
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on omitting the license since we already have a license file at the root of the project?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking formz and very_good_infinite_list as precedence, we should remove this file.

felangel
felangel previously approved these changes Nov 14, 2022
<excludeFolder url="file://$MODULE_DIR$/build" />
<excludeFolder url="file://$MODULE_DIR$/.dart_tool" />
<excludeFolder url="file://$MODULE_DIR$/.pub" />
<excludeFolder url="file://$MODULE_DIR$/example/build" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ignoring .idea, so lets do a git rm --cached .idea

Copy link
Copy Markdown
Contributor Author

@renancaraujo renancaraujo Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not ignoring the root .idea, these are some useful configs.

@renancaraujo renancaraujo merged commit 452d1dd into main Nov 15, 2022
@renancaraujo renancaraujo deleted the feat/add-example branch November 15, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants