Skip to content

chore: widen dart compatibility#20

Merged
felangel merged 1 commit intoVeryGoodOpenSource:mainfrom
passsy:dart-2.12
Nov 16, 2021
Merged

chore: widen dart compatibility#20
felangel merged 1 commit intoVeryGoodOpenSource:mainfrom
passsy:dart-2.12

Conversation

@passsy
Copy link
Contributor

@passsy passsy commented Nov 16, 2021

Description

This package is fully compatible with 2.12 and should be declared that way.

The problem I'm currently running into:

The current Dart SDK version is 2.12.4.

Because mason >=0.0.1-dev.52 depends on pub_updater >=0.1.1 which requires SDK version >=2.13.0 <3.0.0, mason >=0.0.1-dev.52 is forbidden.
So, because sidekick depends on mason ^0.0.1-dev.57, version solving failed.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel changed the title Widen dart compatability chore: widen dart compatibility Nov 16, 2021
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for taking the time to do this!

@felangel felangel merged commit b1ecd64 into VeryGoodOpenSource:main Nov 16, 2021
@passsy passsy deleted the dart-2.12 branch November 16, 2021 14:05
felangel pushed a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants