feat: Allow PubUpdater to be instantiated with custom dart api base url#33
Merged
felangel merged 6 commits intoVeryGoodOpenSource:mainfrom Nov 17, 2022
Merged
Conversation
julienandco
requested review from
felangel,
jorgecoca,
renancaraujo and
wolfenrain
as code owners
julienandco
changed the title
wolfenrain
reviewed
Nov 15, 2022
wolfenrain
approved these changes
Nov 17, 2022
felangel
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added an optional String attribute to the PubUpdater constructor, such that a custom pub api Url can be passed and will be used by the PubUpdater during all the different calls.
Type of Change