Skip to content

feat: add template for creating a flutter plugin#169

Merged
felangel merged 12 commits intomainfrom
add-flutter-plugin
Aug 20, 2021
Merged

feat: add template for creating a flutter plugin#169
felangel merged 12 commits intomainfrom
add-flutter-plugin

Conversation

@denangelov
Copy link
Contributor

Description

feat: add template for creating a flutter plugin

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Aug 19, 2021
@felangel
Copy link
Contributor

@denangelov can we regenerate the bundle using the latest (there were changes made recently)?

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just left a few minor nits but the main thing is we should regenerate the bundle to incorporate all the recent changes in the plugin brick.

@denangelov
Copy link
Contributor Author

@felangel sounds good will regenerate the bundle in VG cli

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@felangel felangel merged commit 82e2a1d into main Aug 20, 2021
@felangel felangel deleted the add-flutter-plugin branch August 20, 2021 19:32
@felangel felangel mentioned this pull request Aug 20, 2021
7 tasks
ahsanf pushed a commit to Arkabyte-Teknologi/very_good_cli that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants