fix: move alert messages to custom method#461
Merged
wolfenrain merged 1 commit intomainfrom Jul 15, 2022
Merged
Conversation
renancaraujo
approved these changes
Jul 15, 2022
felangel
reviewed
Jul 15, 2022
| /// Extension on the Logger class for custom styled logging. | ||
| extension LoggerX on Logger { | ||
| /// Log a message in the "created" style of the CLI. | ||
| void created(String message) { |
Contributor
There was a problem hiding this comment.
Minor but thoughts on calling this something like pretty or emphasis?
Suggested change
| void created(String message) { | |
| void emphasis(String message) { |
Contributor
Author
There was a problem hiding this comment.
I thought having explicit methods for explict type of logging might make more sense for the CLI itself?
Contributor
There was a problem hiding this comment.
I’m fine either way just was thinking about if we have another non created message with the same styling
felangel
approved these changes
Jul 15, 2022
ahsanf
pushed a commit
to Arkabyte-Teknologi/very_good_cli
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After talking with @renancaraujo and @felangel we came to the conclusion that we were abusing the alert message, it is meant to indicate something severe or a call to action but we mostly used it for the pretty colors.
Fixing that by moving to a custom message that uses these pretty colors.
Type of Change