Skip to content

feat: add support for excluding packages#640

Merged
renancaraujo merged 25 commits intoVeryGoodOpenSource:mainfrom
willhlas:feat/exclude-packages
Mar 7, 2023
Merged

feat: add support for excluding packages#640
renancaraujo merged 25 commits intoVeryGoodOpenSource:mainfrom
willhlas:feat/exclude-packages

Conversation

@willhlas
Copy link
Contributor

@willhlas willhlas commented Feb 6, 2023

Description

Adds support for excluding packages when running packages get.

  • very_good packages get -r --ignore=pluginA,pluginB

Closes #636

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@willhlas willhlas marked this pull request as ready for review February 7, 2023 16:54
@willhlas willhlas force-pushed the feat/exclude-packages branch from b688674 to d077383 Compare February 8, 2023 17:08
erickzanardo
erickzanardo previously approved these changes Feb 10, 2023
wolfenrain
wolfenrain previously approved these changes Feb 10, 2023
renancaraujo
renancaraujo previously approved these changes Feb 10, 2023
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to ensure globs are supported?

@willhlas willhlas requested review from felangel and wolfenrain and removed request for felangel and wolfenrain February 13, 2023 16:58
@renancaraujo renancaraujo self-requested a review February 27, 2023 12:32
renancaraujo
renancaraujo previously approved these changes Feb 27, 2023
@renancaraujo renancaraujo added the waiting for response Waiting for follow up label Feb 28, 2023
@willhlas willhlas requested review from renancaraujo and removed request for felangel and wolfenrain March 1, 2023 12:36
felangel
felangel previously approved these changes Mar 2, 2023
willhlas and others added 3 commits March 3, 2023 13:58
@renancaraujo renancaraujo merged commit 3701efa into VeryGoodOpenSource:main Mar 7, 2023
@erickzanardo erickzanardo deleted the feat/exclude-packages branch March 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for response Waiting for follow up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI - feat: support excluding directories

5 participants