From 6de93287b32e923e74ac4c612be85f1f670995b0 Mon Sep 17 00:00:00 2001 From: Renan Araujo Date: Wed, 1 Mar 2023 17:43:30 +0000 Subject: [PATCH 1/2] fix(test_optimizer): mismatch of versions on hook --- .github/workflows/test_optimizer.yaml | 2 +- bricks/test_optimizer/hooks/analysis_options.yaml | 2 +- bricks/test_optimizer/hooks/pubspec.yaml | 2 +- lib/src/commands/test/templates/test_optimizer_bundle.dart | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test_optimizer.yaml b/.github/workflows/test_optimizer.yaml index 5417935b1..cf4187b8b 100644 --- a/.github/workflows/test_optimizer.yaml +++ b/.github/workflows/test_optimizer.yaml @@ -22,7 +22,7 @@ jobs: build_hooks: uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1 with: - dart_sdk: 2.19.0 + dart_sdk: 2.18.0 working_directory: bricks/test_optimizer/hooks verify_bundle: diff --git a/bricks/test_optimizer/hooks/analysis_options.yaml b/bricks/test_optimizer/hooks/analysis_options.yaml index d767e5d39..ff9c544bb 100644 --- a/bricks/test_optimizer/hooks/analysis_options.yaml +++ b/bricks/test_optimizer/hooks/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.4.0.0.yaml +include: package:very_good_analysis/analysis_options.3.1.0.yaml linter: rules: public_member_api_docs: false diff --git a/bricks/test_optimizer/hooks/pubspec.yaml b/bricks/test_optimizer/hooks/pubspec.yaml index cb12ff096..5d517afe2 100644 --- a/bricks/test_optimizer/hooks/pubspec.yaml +++ b/bricks/test_optimizer/hooks/pubspec.yaml @@ -11,4 +11,4 @@ dependencies: dev_dependencies: mocktail: ^0.3.0 test: ^1.22.2 - very_good_analysis: ^4.0.0 + very_good_analysis: ^3.1.0 diff --git a/lib/src/commands/test/templates/test_optimizer_bundle.dart b/lib/src/commands/test/templates/test_optimizer_bundle.dart index 248529ee1..29e83af43 100644 --- a/lib/src/commands/test/templates/test_optimizer_bundle.dart +++ b/lib/src/commands/test/templates/test_optimizer_bundle.dart @@ -35,7 +35,7 @@ final testOptimizerBundle = MasonBundle.fromJson({ { "path": "pubspec.yaml", "data": - "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKZGV2X2RlcGVuZGVuY2llczoKICBtb2NrdGFpbDogXjAuMy4wCiAgdGVzdDogXjEuMjIuMgogIHZlcnlfZ29vZF9hbmFseXNpczogXjQuMC4wCg==", + "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKZGV2X2RlcGVuZGVuY2llczoKICBtb2NrdGFpbDogXjAuMy4wCiAgdGVzdDogXjEuMjIuMgogIHZlcnlfZ29vZF9hbmFseXNpczogXjMuMS4wCg==", "type": "text" }, { From 4ad440b8affb4b69089d7a67e244b5bd324cac20 Mon Sep 17 00:00:00 2001 From: Renan Araujo Date: Wed, 1 Mar 2023 17:46:33 +0000 Subject: [PATCH 2/2] comment --- bricks/test_optimizer/hooks/pubspec.yaml | 3 +++ lib/src/commands/test/templates/test_optimizer_bundle.dart | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/bricks/test_optimizer/hooks/pubspec.yaml b/bricks/test_optimizer/hooks/pubspec.yaml index 5d517afe2..c4284289a 100644 --- a/bricks/test_optimizer/hooks/pubspec.yaml +++ b/bricks/test_optimizer/hooks/pubspec.yaml @@ -8,6 +8,9 @@ dependencies: mason: ">=0.1.0-dev.41 <0.1.0" path: ^1.8.1 + +# Beware: on hooks, even dev dependencies have to be compatible to all dart versions covered by +# the sdk constraints above dev_dependencies: mocktail: ^0.3.0 test: ^1.22.2 diff --git a/lib/src/commands/test/templates/test_optimizer_bundle.dart b/lib/src/commands/test/templates/test_optimizer_bundle.dart index 29e83af43..bd5301fa4 100644 --- a/lib/src/commands/test/templates/test_optimizer_bundle.dart +++ b/lib/src/commands/test/templates/test_optimizer_bundle.dart @@ -35,7 +35,7 @@ final testOptimizerBundle = MasonBundle.fromJson({ { "path": "pubspec.yaml", "data": - "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKZGV2X2RlcGVuZGVuY2llczoKICBtb2NrdGFpbDogXjAuMy4wCiAgdGVzdDogXjEuMjIuMgogIHZlcnlfZ29vZF9hbmFseXNpczogXjMuMS4wCg==", + "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKCiMgQmV3YXJlOiBvbiBob29rcywgZXZlbiBkZXYgZGVwZW5kZW5jaWVzIGhhdmUgdG8gYmUgY29tcGF0aWJsZSB0byBhbGwgZGFydCB2ZXJzaW9ucyBjb3ZlcmVkIGJ5CiMgdGhlIHNkayBjb25zdHJhaW50cyBhYm92ZQpkZXZfZGVwZW5kZW5jaWVzOgogIG1vY2t0YWlsOiBeMC4zLjAKICB0ZXN0OiBeMS4yMi4yCiAgdmVyeV9nb29kX2FuYWx5c2lzOiBeMy4xLjAK", "type": "text" }, {