Skip to content

feat: add optional keepScreenshot option to vrtTrack#189

Merged
pashidlos merged 2 commits intoVisual-Regression-Tracker:masterfrom
dimitriharding:feature/optional-keep-screenshot
Jul 12, 2022
Merged

feat: add optional keepScreenshot option to vrtTrack#189
pashidlos merged 2 commits intoVisual-Regression-Tracker:masterfrom
dimitriharding:feature/optional-keep-screenshot

Conversation

@dimitriharding
Copy link
Contributor

@dimitriharding dimitriharding commented Jul 5, 2022

There is already a PR out for this change, but the requested changes were not addressed, it's been months.

I am creating this PR so we can have this option in the cypress agent, especially since I have a use case for it.

@dimitriharding
Copy link
Contributor Author

@pashidlos Made updates and also tested locally that by adding keepScreenshot to true on vrtTrack options, the image is kept on the local system. By default the screenshot it removed as expected.

Screen Shot 2022-07-06 at 9 03 34 AM

@pashidlos pashidlos merged commit d711fc4 into Visual-Regression-Tracker:master Jul 12, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants