fix(project-backup): validate repository before restore#19061
Merged
nijel merged 1 commit intoWeblateOrg:mainfrom Apr 17, 2026
Merged
fix(project-backup): validate repository before restore#19061nijel merged 1 commit intoWeblateOrg:mainfrom
nijel merged 1 commit intoWeblateOrg:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens project backup imports by revalidating component VCS URLs (repository + push) during backup validation, preventing restores from introducing components pointing at prohibited/private targets.
Changes:
- Revalidate component
repoandpushURLs duringProjectBackup.validate()by applyingvalidate_repo_url. - Add regression tests ensuring restore validation rejects internal/non-public repo and push URLs.
- Document the behavior change in the 5.17.1 changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
weblate/trans/backups.py |
Validates component repo/push URLs while loading component metadata from the backup archive. |
weblate/trans/tests/test_backups.py |
Adds tests that tamper a backup’s component JSON and assert validate() rejects prohibited URLs. |
docs/changes.rst |
Notes the new revalidation step during project backup import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.