Skip to content

Conversation

@fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented May 17, 2025

What Changed

Evidence

Integration-Test

I’d appreciate it if you could check it when you have time🙏

@fukusuket fukusuket requested a review from Copilot May 17, 2025 08:37
@fukusuket fukusuket self-assigned this May 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the YAML rule format to make the ruletype field optional.

  • Removed ruletype from the list of required keys.
  • Eliminated the ruletype-specific validation block.
  • Simplified rule format checks in the YAML processing function.
Comments suppressed due to low confidence (2)

src/yaml.rs:824

  • [nitpick] With ruletype now optional, consider adding a conditional check to validate its value (if provided) to ensure consistency with accepted types (e.g., "hayabusa" or "sigma").
"ruletype",

src/yaml.rs:839

  • [nitpick] Ensure that the removal of the ruletype validation logic is aligned with the overall schema strategy; if ruletype is supplied by users, consider documenting the expected outcome when its value does not meet the typical standards.
match key {

@fukusuket fukusuket added the enhancement New feature or request label May 17, 2025
@fukusuket fukusuket added this to the 3.3.0 milestone May 17, 2025
@fukusuket fukusuket marked this pull request as ready for review May 17, 2025 09:04
@fukusuket fukusuket requested a review from YamatoSecurity May 17, 2025 09:05
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit f7813fb into main May 17, 2025
5 checks passed
@YamatoSecurity YamatoSecurity deleted the exclude-ruletype-for-rule-validation-check branch May 17, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants