-
Notifications
You must be signed in to change notification settings - Fork 260
fix: replace hyphen with empty string in event ID handling #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes event ID handling by replacing hyphen fallback values with empty strings. The change ensures that when event IDs cannot be parsed or are missing, an empty string is used instead of a hyphen character.
- Replace hyphen with empty string in event ID fallback handling
- Update both event ID extraction and profile converter initialization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
YamatoSecurity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Thanks so much!! LGTM!
What Changed
-for integer fields #1692Evidence
Integration-Test
I’d appreciate it if you could check it when you have time🙏