Address review comments.

    - Rename 'preferredOnly' to 'usePreferredOnly'.
    - Get rid of 'firstOnly' altogether.
    - Fix tests.

Author: busykai

.brackets.json

@@ -11,8 +11,7 @@
     "language": {
         "javascript": {
             "linting.prefer": ["JSLint", "JSHint"],
-            "linting.preferredOnly": true,
-            "linting.firstOnly": false
+            "linting.usePreferredOnly": true
         }
     },
     "path": {

src/language/CodeInspection.js

@@ -79,8 +79,7 @@ define(function (require, exports, module) {
         PREF_COLLAPSED          = "collapsed",
         PREF_ASYNC_TIMEOUT      = "asyncTimeout",
         PREF_PREFER_PROVIDERS   = "prefer",
-        PREF_PREFERRED_ONLY     = "preferredOnly",
-        PREF_FIRST_ONLY         = "firstOnly";
+        PREF_PREFERRED_ONLY     = "usePreferredOnly";
 
     var prefs = PreferencesManager.getExtensionPrefs("linting");
 
@@ -171,7 +170,6 @@ define(function (require, exports, module) {
 
             prefPreferredProviderNames  = prefs.get(PREF_PREFER_PROVIDERS, context),
             prefPreferredOnly           = prefs.get(PREF_PREFERRED_ONLY, context),
-            prefFirstOnly               = prefs.get(PREF_FIRST_ONLY, context),
 
             providers;
 
@@ -197,9 +195,6 @@ define(function (require, exports, module) {
         } else {
             providers = installedProviders;
         }
-        if (prefFirstOnly === true) { // implies suppressing others
-            return providers.slice(0, 1);
-        }
         return providers;
     }
 
@@ -676,7 +671,6 @@ define(function (require, exports, module) {
     exports._PREF_ASYNC_TIMEOUT     = PREF_ASYNC_TIMEOUT;
     exports._PREF_PREFER_PROVIDERS  = PREF_PREFER_PROVIDERS;
     exports._PREF_PREFERRED_ONLY    = PREF_PREFERRED_ONLY;
-    exports._PREF_FIRST_ONLY        = PREF_FIRST_ONLY;
 
     // Public API
     exports.register            = register;

test/spec/CodeInspection-test.js

@@ -334,35 +334,23 @@ define(function (require, exports, module) {
                     expect(providers).toNotBe(null);
                     expect(_.pluck(providers, "name")).toEqual(["html5", "html1", "html2", "html3", "html4"]);
 
-                    setAtLocation(CodeInspection._PREF_FIRST_ONLY, true);
-                    providers = CodeInspection.getProvidersForPath("index.html");
-                    expect(providers).toNotBe(null);
-                    expect(_.pluck(providers, "name")).toEqual(["html5"]);
-
                     setAtLocation(CodeInspection._PREF_PREFER_PROVIDERS, ["html19", "html100"]);
-                    setAtLocation(CodeInspection._PREF_FIRST_ONLY, true);
                     providers = CodeInspection.getProvidersForPath("index.html");
                     expect(providers).toNotBe(null);
-                    expect(_.pluck(providers, "name")).toEqual(["html1"]);
+                    expect(_.pluck(providers, "name")).toEqual(["html1", "html2", "html3", "html4", "html5"]);
 
                     setAtLocation(CodeInspection._PREF_PREFERRED_ONLY, true);
                     providers = CodeInspection.getProvidersForPath("test.html");
                     expect(providers).toEqual([]);
 
                     setAtLocation(CodeInspection._PREF_PREFER_PROVIDERS, ["html2", "html1"]);
                     setAtLocation(CodeInspection._PREF_PREFERRED_ONLY, true);
-                    setAtLocation(CodeInspection._PREF_FIRST_ONLY, false);
                     providers = CodeInspection.getProvidersForPath("c:/temp/another.html");
                     expect(providers).toNotBe(null);
                     expect(_.pluck(providers, "name")).toEqual(["html2", "html1"]);
 
                     setAtLocation(CodeInspection._PREF_PREFER_PROVIDERS, undefined);
                     setAtLocation(CodeInspection._PREF_PREFERRED_ONLY, undefined);
-                    setAtLocation(CodeInspection._PREF_FIRST_ONLY, true);
-                    providers = CodeInspection.getProvidersForPath("test/index.html");
-                    expect(_.pluck(providers, "name")).toEqual(["html1"]);
-                    
-                    setAtLocation(CodeInspection._PREF_FIRST_ONLY, undefined);
                     providers = CodeInspection.getProvidersForPath("index.html");
                     expect(providers).toNotBe(null);
                     expect(_.pluck(providers, "name")).toEqual(["html1", "html2", "html3", "html4", "html5"]);