Fix IntelliJ warnings and ESLint errors

- Use barrel import for queryGenerator classes
- Rename KNOWN_ARRAY_FIELDS to knownArrayFields for naming convention
- Fix prefer-nullish-coalescing in unionAllHasForEach
- Remove unused buildApplyWhereClauses method

All tests continue to pass (110 passing, 8 experimental failing as expected).

Author: johngrimes

src/queryGenerator.ts

@@ -11,15 +11,15 @@ import {
   ViewDefinitionConstant,
   ViewDefinitionSelect,
 } from "./types.js";
-import { PathParser } from "./queryGenerator/PathParser.js";
 import {
+  PathParser,
   SelectCombination,
   SelectCombinationExpander,
-} from "./queryGenerator/SelectCombinationExpander.js";
-import { ForEachProcessor } from "./queryGenerator/ForEachProcessor.js";
-import { SelectClauseBuilder } from "./queryGenerator/SelectClauseBuilder.js";
-import { WhereClauseBuilder } from "./queryGenerator/WhereClauseBuilder.js";
-import { ColumnExpressionGenerator } from "./queryGenerator/ColumnExpressionGenerator.js";
+  ForEachProcessor,
+  SelectClauseBuilder,
+  WhereClauseBuilder,
+  ColumnExpressionGenerator,
+} from "./queryGenerator/index.js";
 
 export interface QueryGeneratorOptions {
   tableName?: string;

src/queryGenerator/ForEachProcessor.ts

@@ -83,8 +83,7 @@ export class ForEachProcessor {
   private unionAllHasForEach(unionAllOptions: ViewDefinitionSelect[]): boolean {
     return unionAllOptions.some(
       (unionOption) =>
-        unionOption.forEach ||
-        unionOption.forEachOrNull ||
+        (unionOption.forEach ?? unionOption.forEachOrNull) !== undefined ||
         (unionOption.select && this.hasForEachInSelects(unionOption.select)),
     );
   }

src/queryGenerator/PathParser.ts

@@ -32,7 +32,7 @@ export interface SegmentIndexingResult {
  * Handles parsing and interpretation of FHIRPath expressions.
  */
 export class PathParser {
-  private static readonly KNOWN_ARRAY_FIELDS = [
+  private static readonly knownArrayFields = [
     "name",
     "telecom",
     "address",
@@ -106,7 +106,7 @@ export class PathParser {
       const indexedPath = segments
         .map((seg) => {
           const cleanSeg = seg.replace(/\[.*]/, "");
-          if (PathParser.KNOWN_ARRAY_FIELDS.includes(cleanSeg)) {
+          if (PathParser.knownArrayFields.includes(cleanSeg)) {
             return `${cleanSeg}[${arrayIndex}]`;
           }
           return cleanSeg;
@@ -148,7 +148,7 @@ export class PathParser {
       const segment = segments[i];
       const cleanSegment = segment.replace(/\[.*]/, "");
 
-      if (PathParser.KNOWN_ARRAY_FIELDS.includes(cleanSegment)) {
+      if (PathParser.knownArrayFields.includes(cleanSegment)) {
         arraySegments.push(segments.slice(0, i + 1).join("."));
       }
     }

src/queryGenerator/WhereClauseBuilder.ts

@@ -84,24 +84,4 @@ export class WhereClauseBuilder {
 
     return `(${conditions.join(") AND (")})`;
   }
-
-  /**
-   * Build WHERE clause conditions for array filtering in APPLY operations.
-   */
-  buildApplyWhereClauses(
-    arrayIndex: number | null | undefined,
-    whereCondition: string | null | undefined,
-  ): string[] {
-    const whereClauses: string[] = [];
-
-    if (arrayIndex !== null && arrayIndex !== undefined) {
-      whereClauses.push(`[key] = '${arrayIndex}'`);
-    }
-
-    if (whereCondition !== null && whereCondition !== undefined) {
-      whereClauses.push(whereCondition);
-    }
-
-    return whereClauses;
-  }
 }