Skip to content

Commit 9ad36ec

Browse files
committed
Fix dependency issues in workflow
1 parent ce817a8 commit 9ad36ec

File tree

3 files changed

+10
-20
lines changed

3 files changed

+10
-20
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,12 @@ jobs:
103103
sqlserver:
104104
image: mcr.microsoft.com/mssql/server:${{ matrix.sql-version }}
105105
env:
106-
SA_PASSWORD: TestPassword123!
106+
SA_PASSWORD: ${{ secrets.SA_PASSWORD }}
107107
ACCEPT_EULA: Y
108108
ports:
109109
- 1433:1433
110110
options: >-
111-
--health-cmd "/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P TestPassword123! -Q 'SELECT 1'"
111+
--health-cmd "/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -Q 'SELECT 1'"
112112
--health-interval 10s
113113
--health-timeout 5s
114114
--health-retries 5
@@ -139,7 +139,9 @@ jobs:
139139
run: npm run format:check
140140

141141
- name: Create test database
142-
run: sqlcmd -S localhost -U sa -P "TestPassword123!" -Q "CREATE DATABASE testdb"
142+
run: sqlcmd -S localhost -U sa -P "${SA_PASSWORD}" -Q "CREATE DATABASE testdb"
143+
env:
144+
SA_PASSWORD: ${{ secrets.SA_PASSWORD }}
143145

144146
- name: Run tests
145147
run: npm test
@@ -148,4 +150,4 @@ jobs:
148150
MSSQL_HOST: localhost
149151
MSSQL_DATABASE: testdb
150152
MSSQL_USER: sa
151-
MSSQL_PASSWORD: TestPassword123!
153+
MSSQL_PASSWORD: ${{ secrets.SA_PASSWORD }}

package-lock.json

Lines changed: 3 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
],
3434
"license": "UNLICENSED",
3535
"dependencies": {
36+
"antlr4ts": "^0.5.0-alpha.4",
3637
"fhirpath": "^3.15.1"
3738
},
3839
"devDependencies": {

0 commit comments

Comments
 (0)