Skip to content

Patch onOutsideClick default value in the DayPickerSingleDateController#1115

Merged
majapw merged 1 commit intomasterfrom
maja-patch-onOutsideClick-defaultProp-value
Apr 13, 2018
Merged

Patch onOutsideClick default value in the DayPickerSingleDateController#1115
majapw merged 1 commit intomasterfrom
maja-patch-onOutsideClick-defaultProp-value

Conversation

@majapw
Copy link
Copy Markdown
Collaborator

@majapw majapw commented Apr 13, 2018

Fixes #1114

Whoops, I changed the way the DayPickerSingleDateController onOutsideClick prop looked to better match the DayPickerRangeController, but did not update the default prop value.

to: @ljharb @ricardobrandao

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression test?

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Apr 13, 2018
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.824% when pulling 083f1c0 on maja-patch-onOutsideClick-defaultProp-value into db0c49b on master.

@majapw
Copy link
Copy Markdown
Collaborator Author

majapw commented Apr 13, 2018

@ljharb I think this requires both a full mount and actually simulating an outside click on the component to test... :/ I will think about how best to approach this problem.

@majapw majapw merged commit f8562f2 into master Apr 13, 2018
@majapw majapw deleted the maja-patch-onOutsideClick-defaultProp-value branch April 13, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch: fixes/refactors/etc Anything that's not major or minor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants