Conversation
majapw
force-pushed
the
maja-remove-default-styling-from-custom-month-nav
branch
from
5486ecf to
2f2f15c
Compare
majapw
changed the title
majapw
added
the
semver-major: breaking change
majapw
force-pushed
the
maja-remove-default-styling-from-custom-month-nav
branch
from
2f2f15c to
c1d8979
Compare
a15n
reviewed
Jun 19, 2018
a15n
left a comment
a15n
left a comment
There was a problem hiding this comment.
Excited to see this flexibility added to the library
ljharb
approved these changes
Jun 21, 2018
| ); | ||
| } | ||
|
|
||
| const isDefaultNav = isDefaultNavNext || (!isVerticalScrollable && isDefaultNavPrev); |
Member
There was a problem hiding this comment.
this might be more clear as
const isDefaultNav = isVerticalScrollable ? isDefaultNavNext : (isDefaultNavNext || isDefaultNavPrev);(i found the negation confusing)
majapw
force-pushed
the
maja-remove-default-styling-from-custom-month-nav
branch
from
c1d8979 to
47d2da8
Compare
This was referenced Mar 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes all default styling from custom navigation buttons (including position). This is a breaking change.
I'm wondering if I should take this opportunity to change navNext/navPrev to render props a la the rest of the repo. Thoughts?
Screenshots:
Default
Custom
to: @ljharb @amhunt