Rename renderMonth to renderMonthTitle and renderCaption to renderMonthElement#1220
Merged
Rename renderMonth to renderMonthTitle and renderCaption to renderMonthElement#1220
Conversation
majapw
added
the
semver-major: breaking change
Contributor
|
@majapw FWIW I actually like the combination of |
ljharb
reviewed
Jun 19, 2018
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Per discussion, I think renderMonthText and renderMonthElement work great, and should be mutually exclusive
majapw
force-pushed
the
maja-clean-up-caption-month-naming
branch
from
1d1f4d8 to
4710d99
Compare
majapw
force-pushed
the
maja-clean-up-caption-month-naming
branch
from
4710d99 to
6a5d8ee
Compare
backwardok
approved these changes
Jun 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this make sense?
@GoGoCarl @ljharb @backwardok
@backwardok suggested
renderMonthTextandrenderMonthHTMLbut I don't know that that's very inline with other props in react-dates.titlematches the current nomenclature?renderTitleElementmight be clearer? Idk.I wanted to get this out with the latest breaking version.