Skip to content

Add SingleDatePickerInputController component#1360

Merged
majapw merged 1 commit intomasterfrom
maja-add-SingleDatePickerInputController
Sep 14, 2018
Merged

Add SingleDatePickerInputController component#1360
majapw merged 1 commit intomasterfrom
maja-add-SingleDatePickerInputController

Conversation

@majapw
Copy link
Copy Markdown
Collaborator

@majapw majapw commented Sep 14, 2018

This is the first step to creating a component structure that will allow consumers to asynchronously load the picker.

Basically, this creates an input controller component similar to the DateRangePickerInputController that takes care of everything related to input and input validation. There should be no functional change to any of the main components.

to: @ljharb @lencioni @noratarano

@majapw majapw added the semver-minor: new stuff Any feature or API addition. label Sep 14, 2018
Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Comment thread src/components/SingleDatePicker.jsx
Comment thread src/components/SingleDatePicker.jsx
Comment thread src/components/SingleDatePickerInput.jsx
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 84.915% when pulling e376d2f on maja-add-SingleDatePickerInputController into 90c7506 on master.

@majapw majapw merged commit d857a24 into master Sep 14, 2018
@ljharb ljharb deleted the maja-add-SingleDatePickerInputController branch September 14, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor: new stuff Any feature or API addition.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants