Add tests for minDate and maxDate props in DateRangePicker#1794
Merged
alanhamlett merged 2 commits intoreact-dates:masterfrom Sep 20, 2019
v47:DateRangePicker-minDate-maxDate-props-tests
Merged
Add tests for minDate and maxDate props in DateRangePicker#1794alanhamlett merged 2 commits intoreact-dates:masterfrom v47:DateRangePicker-minDate-maxDate-props-tests
alanhamlett merged 2 commits intoreact-dates:masterfrom
v47:DateRangePicker-minDate-maxDate-props-tests
Conversation
Collaborator
|
We're not testing that other props are passed through, should we add tests for all passed through props while we're at it? |
Contributor
Author
|
@ljharb, I sorry for the absent tests in a first place. |
Contributor
Author
|
@alanhamlett comunications between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing tests for minDate and maxDate props in DateRangePicker.
From #1793