Fix logic for applying default navigation button styling#1898
Merged
nkinser merged 2 commits intoreact-dates:masterfrom Jan 15, 2020
Merged
Fix logic for applying default navigation button styling#1898nkinser merged 2 commits intoreact-dates:masterfrom
nkinser merged 2 commits intoreact-dates:masterfrom
Conversation
nkinser
force-pushed
the
nk--fix-nav-default-styles
branch
from
dfd5aec to
4c67f2b
Compare
nkinser
changed the title
ljharb
added
the
semver-patch: fixes/refactors/etc
ljharb
approved these changes
Jan 14, 2020
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Any chance of a regression test?
nkinser
force-pushed
the
nk--fix-nav-default-styles
branch
2 times, most recently
from
1dc1611 to
159e444
Compare
nkinser
force-pushed
the
nk--fix-nav-default-styles
branch
7 times, most recently
from
4e844e9 to
05635fb
Compare
nkinser
force-pushed
the
nk--fix-nav-default-styles
branch
from
05635fb to
1057719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't set
isDefaultNavPrevorisDefaultNavNextto true if custom navigation buttons are provided.Before
After