Skip to content

Be able to highlight day#206

Merged
majapw merged 2 commits intoreact-dates:masterfrom
sideroad:highlighted_day
Dec 19, 2016
Merged

Be able to highlight day#206
majapw merged 2 commits intoreact-dates:masterfrom
sideroad:highlighted_day

Conversation

@sideroad
Copy link
Copy Markdown
Contributor

@sideroad sideroad commented Dec 2, 2016

Be able to specify highlight day.
Currently, I specified yellow color as highlighted.
If there is any better color, Plz let me know.

#36

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 86.715% when pulling 82d1c71 on sideroad:highlighted_day into 32bb58d on airbnb:master.

Copy link
Copy Markdown
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we have a screenshot of the example in the PR description? I think that would be helpful.

Comment thread css/variables.scss Outdated
$react-dates-color-primary-shade-2: #66e2da !default;
$react-dates-color-primary-shade-3: #80e8e0 !default;
$react-dates-color-primary-shade-4: #b2f1ec !default;
$react-dates-color-primary-shade-5: #ffe8bc !default;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since this isn't a shade of react-dates-color-primary we should name this react-dates-color-highlighted

@Kriget
Copy link
Copy Markdown

Kriget commented Dec 15, 2016

would really love this feature. could this feature be merged into master in the foreseeable future?

@majapw
Copy link
Copy Markdown
Collaborator

majapw commented Dec 15, 2016

As soon as the comments are addressed, I think we can move forward.

@sideroad
Copy link
Copy Markdown
Contributor Author

Sorry for late response.

Here is a screenshot for it!
2016-12-18 10 49 35

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 86.443% when pulling 015120c on sideroad:highlighted_day into b662dd2 on airbnb:master.

@majapw
Copy link
Copy Markdown
Collaborator

majapw commented Dec 18, 2016

Awesome! Looks great to me. :D Can you rebase squash the commits down into 1 @sideroad? I'll merge it in after that! 👍

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 86.443% when pulling 015120c on sideroad:highlighted_day into b662dd2 on airbnb:master.

@majapw
Copy link
Copy Markdown
Collaborator

majapw commented Dec 19, 2016

Hi @sideroad! Instead of pressing the Update branch button in the UI, can you run git rebase master and then git rebase -i in the terminal to squash the commits down into one commit?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 86.443% when pulling fa565ed on sideroad:highlighted_day into b662dd2 on airbnb:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 86.443% when pulling fa565ed on sideroad:highlighted_day into b662dd2 on airbnb:master.

@majapw majapw merged commit b71f1e7 into react-dates:master Dec 19, 2016
@majapw majapw added the semver-minor: new stuff Any feature or API addition. label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor: new stuff Any feature or API addition.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants