Address some issues introduced by the a11y PR

[majapw]

Sorry this took so long! This should address issues raised in #427.

Namely, a handful of things happen in this PR:

1. The keyboard shortcuts panel button is now transparent instead of white. It also has a higher z-index so it doesn't flash in transitions.
2. The panel has an overflow of auto so it doesn't totally crap out on single month datepickers
3. The alignment of text in the panel has been adjusted a bit to support the single month case.
4. enableOutsideDays was having some weirdness with using the keyboard to transition months. This has been fixed.
5. There is now a prop to hide the panel entirely. The recommendation is still to either style the panel to best suit your use-case or to communicate the keyboard shortcuts elsewhere, but yaknow.

to: @airbnb/webinfra

[lencioni]

Sorry this took so long!

I don't think you need to apologize. You are doing a great job!

[lencioni]

Why 2 here? Can this be based off of a variable to make the dependency more explicit?

[majapw]

good idea!

[coveralls]

Coverage decreased (-0.4%) to 83.512% when pulling 6212751 on maja-fix-a11y-issues into 3815516 on master.

[coveralls]

Coverage remained the same at 83.961% when pulling eaf361a on maja-fix-a11y-issues into 3815516 on master.

[sag1v]

@majapw Great work, thank you.

There is now a prop to hide the panel entirely

What is the name of the prop? (not that i will use it but yaknow lol)

[majapw]

hideKeyboardShortcutsPanel on both the DRP and the SDP

[ljharb]

I'm a very strong -1 for hiding the explanatory shortcut panel when shortcuts still work - I think if they work, the explanation needs to be easily reachable, otherwise people might accidentally type something and have no idea why it triggered a change.

[majapw]

@ljharb while I believe we should provide a reasonable default option for explaining the keyboard shortcuts (which we do, with the panel), I think that because we are providing a tool for developers to integrate into their own products, we should allow for them to customize how they decide to convey this information to their users, whether it is embedded on the page directly, in a modal separate from the datepicker completely, or something I haven't yet considered. We should not force developers to use our solution, and that is why I added the hideKeyboardShortcutsPanel option.

My first recommendation would still be to use css overrides to style the panel to fit your use case, but I want to provide an option to do your own thing as well. This is why I think this prop makes a lot of sense.

[ljharb]

I'm still not a fan of hiding the shortcut panel, but after some offline discussion with @majapw I'm definitely not a blocker.

[coveralls]

Coverage remained the same at 83.961% when pulling bf6fa0e on maja-fix-a11y-issues into 3815516 on master.

[coveralls]

Coverage remained the same at 83.961% when pulling e301ced on maja-fix-a11y-issues into 3815516 on master.

[kbariotis]

Aw! I came too late! :( Shouldn't README be updated too with the newly added hideKeyboardShortcutsPanel flag?