DayPickerSingleDateController support phrases. Changed phrases state …#623
DayPickerSingleDateController support phrases. Changed phrases state …#623majapw merged 3 commits intoreact-dates:masterfrom
Conversation
ljharb
left a comment
There was a problem hiding this comment.
Thanks! Would you mind adding a regression test for this?
| renderCalendarInfo, | ||
| isFocused, | ||
| isRTL, | ||
| phrases |
There was a problem hiding this comment.
This line needs a trailing comma
majapw
left a comment
There was a problem hiding this comment.
This looks good to me! :) This was a bit of copy/pasta breakage from the DayPickerRangeController which does have a stateful phrases object.
|
@davidskoog can you add a regression test for this? That's all I'm waiting on :-) |
Per discussion; let's bring this in now but ASAP ensure we're testing all the phrases props.
|
Hi again @ljharb. Sorry for this late reply. I'm have been on vacation for a time. I see that you merged my pull request, exciting. I don't know what a regression test is but until next time I will find out. // David |
|
@davidskoog just an automated test to prevent this specific issue from occurring in the future - i.e., from "regressing". |
DayPickerSingleDateController support phrases. Changed phrases state to props.
When using DayPickerSingleDateController I'm not able to use phrases for language translations.
Here is a suggestion for a solution.