Conversation
ljharb
left a comment
There was a problem hiding this comment.
I’m not sure what the semver label should be for this PR.
| export const FANG_HEIGHT_PX = 10; | ||
| export const DEFAULT_VERTICAL_SPACING = 22; | ||
|
|
||
| export const MODIFIER_KEY_NAMES = ['Shift', 'Control', 'Alt', 'Meta']; |
There was a problem hiding this comment.
Can this be a Set instead of an array?
There was a problem hiding this comment.
Yep I can do that.
There was a problem hiding this comment.
Done. (was going to say "all set" 😝)
|
I think this is a patch. These are all just fixes, there isn't any breaking changes and nothing new really. Now the Keyboard Shortcuts Panel will close using the Enter key where as before it was only Spacebar and Esc but that was really a miss, so I consider this fixing that not adding something new. |
|
@majapw just want to bump this if you have a sec to take a look now that you're back from vacay. ;) |
|
(it'll need a rebase also) |
… open so that the correct keys are being used to close the panel.
0cb4ea1 to
db515e7
Compare
|
Pushed rebase. 👍 |
|
Looking now! :) |
majapw
left a comment
There was a problem hiding this comment.
Looks wonderful! Thank you.
I found that the event.key value for the spacebar key is not 'Space' at all 😳 but is either ' ' or 'Spacebar' on older browsers
I too had this issue. :P
This is a combination of a few things: