Skip to content

[Fix] Keyboard nav issues#916

Merged
ljharb merged 3 commits intomasterfrom
fix_keyboard_nav_issues
Jan 3, 2018
Merged

[Fix] Keyboard nav issues#916
ljharb merged 3 commits intomasterfrom
fix_keyboard_nav_issues

Conversation

@erin-doyle
Copy link
Copy Markdown
Collaborator

@erin-doyle erin-doyle commented Dec 22, 2017

This is a combination of a few things:

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.009%) to 85.533% when pulling 4465651 on fix_keyboard_nav_issues into f0b6f2f on master.

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure what the semver label should be for this PR.

Comment thread src/constants.js Outdated
export const FANG_HEIGHT_PX = 10;
export const DEFAULT_VERTICAL_SPACING = 22;

export const MODIFIER_KEY_NAMES = ['Shift', 'Control', 'Alt', 'Meta'];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a Set instead of an array?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I can do that.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (was going to say "all set" 😝)

@erin-doyle
Copy link
Copy Markdown
Collaborator Author

I think this is a patch. These are all just fixes, there isn't any breaking changes and nothing new really. Now the Keyboard Shortcuts Panel will close using the Enter key where as before it was only Spacebar and Esc but that was really a miss, so I consider this fixing that not adding something new.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.009%) to 85.533% when pulling 0cb4ea1 on fix_keyboard_nav_issues into f0b6f2f on master.

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Dec 23, 2017
ljharb
ljharb previously approved these changes Dec 23, 2017
Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erin-doyle
Copy link
Copy Markdown
Collaborator Author

@majapw just want to bump this if you have a sec to take a look now that you're back from vacay. ;)

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Jan 3, 2018

(it'll need a rebase also)

@erin-doyle
Copy link
Copy Markdown
Collaborator Author

Pushed rebase. 👍

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.009%) to 86.257% when pulling db515e7 on fix_keyboard_nav_issues into 9780545 on master.

@majapw
Copy link
Copy Markdown
Collaborator

majapw commented Jan 3, 2018

Looking now! :)

Copy link
Copy Markdown
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful! Thank you.

I found that the event.key value for the spacebar key is not 'Space' at all 😳 but is either ' ' or 'Spacebar' on older browsers

I too had this issue. :P

@ljharb ljharb merged commit 1331539 into master Jan 3, 2018
@ljharb ljharb deleted the fix_keyboard_nav_issues branch January 3, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch: fixes/refactors/etc Anything that's not major or minor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants