Conversation
majapw
added
the
semver-patch: fixes/refactors/etc
ljharb
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have started using the CustomizableCalendarDay (again, not recommended but a very specific way of doing a very specific thing), I have found an issue where custom styles always override default styles. So, if you happen to have a day that is both blocked by minimum nights and selected (which happens all the time for a selected-start day with a minimum nights value greater than 0), if you have customized the minimum nights but not the selection, the minimum nights styling will always win.
We do not want this.
By moving the default stylings out of the StyleSheet and into props as default values, we address this issue.
to: @ljharb @erin-doyle @gabergg @noratarano @airbnb/webinfra