Skip to content

Conversation

@alexaka1
Copy link
Owner

@alexaka1 alexaka1 commented Oct 16, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to route builds by language, separating C# into its own build path.
    • Automated builds now run for non-C# languages; C# builds run via a dedicated C# build step.
    • Preserved and streamlined code analysis step while clarifying build guidance in workflow comments.

Copilot AI review requested due to automatic review settings October 16, 2025 09:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: 9d0dbcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the CodeQL workflow to use a custom build command for C# projects instead of relying on the autobuild action. The autobuild step is now conditionally skipped for C# projects, and a new manual build step using dotnet build -c Release has been added specifically for the C# language.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 36 dependencies

Third-party software list

This page lists the third-party software dependencies used in Distroless

Dependency Version Licenses
AspNetCore.HealthChecks.UI.Core 9.0.0 Apache-2.0
Microsoft.DotNet.ILCompiler 8.0.21 MIT
Microsoft.DotNet.ILCompiler 9.0.10 MIT
Microsoft.Extensions.Configuration.Abstractions 9.0.9 MIT
Microsoft.Extensions.Configuration.Binder 9.0.9 MIT
Microsoft.Extensions.Configuration.CommandLine 9.0.9 MIT
Microsoft.Extensions.Configuration.EnvironmentVariables 9.0.9 MIT
Microsoft.Extensions.Configuration.FileExtensions 9.0.9 MIT
Microsoft.Extensions.Configuration.Json 9.0.9 MIT
Microsoft.Extensions.Configuration.UserSecrets 9.0.9 MIT
Microsoft.Extensions.Configuration 9.0.9 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 9.0.9 MIT
Microsoft.Extensions.DependencyInjection 9.0.9 MIT
Microsoft.Extensions.Diagnostics.Abstractions 9.0.9 MIT
Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions 9.0.9 MIT
Microsoft.Extensions.Diagnostics.HealthChecks 9.0.9 MIT
Microsoft.Extensions.Diagnostics 9.0.9 MIT
Microsoft.Extensions.FileProviders.Abstractions 9.0.9 MIT
Microsoft.Extensions.FileProviders.Physical 9.0.9 MIT
Microsoft.Extensions.FileSystemGlobbing 9.0.9 MIT
Microsoft.Extensions.Hosting.Abstractions 9.0.9 MIT
Microsoft.Extensions.Hosting 9.0.9 MIT
Microsoft.Extensions.Http 9.0.9 MIT
Microsoft.Extensions.Logging.Abstractions 9.0.9 MIT
Microsoft.Extensions.Logging.Configuration 9.0.9 MIT
Microsoft.Extensions.Logging.Console 9.0.9 MIT
Microsoft.Extensions.Logging.Debug 9.0.9 MIT
Microsoft.Extensions.Logging.EventLog 9.0.9 MIT
Microsoft.Extensions.Logging.EventSource 9.0.9 MIT
Microsoft.Extensions.Logging 9.0.9 MIT
Microsoft.Extensions.Options.ConfigurationExtensions 9.0.9 MIT
Microsoft.Extensions.Options 9.0.9 MIT
Microsoft.Extensions.Primitives 9.0.9 MIT
Microsoft.NET.ILLink.Tasks 8.0.21 MIT
Microsoft.NET.ILLink.Tasks 9.0.10 MIT
System.Diagnostics.EventLog 9.0.9 MIT
Contact Qodana team

Contact us at [email protected]

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The CodeQL GitHub Actions workflow matrix was changed to include language-specific entries; Autobuild now runs only for non-C# matrix entries, a dedicated C# build step runs dotnet build for C#, the commented manual build block was removed, and CodeQL analysis remains with language categorization.

Changes

Cohort / File(s) Summary
CodeQL workflow configuration
​.github/workflows/codeql.yml
Replaced flat matrix with include-based entries for actions and csharp; made Autobuild conditional (if: matrix.language != 'csharp'); added Build C# Application step conditional on matrix.language == 'csharp' running dotnet build Distroless.sln -c Release with MSBuild properties; removed commented/manual build block; retained Perform CodeQL Analysis step with language category.

Sequence Diagram(s)

sequenceDiagram
  participant GH as GitHub Actions
  participant Job as Matrix Job
  participant Autobuild as Autobuild Step
  participant Dotnet as Build C# Application
  participant CodeQL as CodeQL Analysis

  Note over GH,Job: Matrix entries:\n- language: actions (autobuild)\n- language: csharp (c# build)
  GH->>Job: start job for matrix.language
  alt matrix.language != "csharp"
    Job->>Autobuild: run Autobuild (OS shell steps)
    Autobuild-->>Job: artifacts
  else matrix.language == "csharp"
    Job->>Dotnet: run `dotnet build Distroless.sln -c Release` (MSBuild props)
    Dotnet-->>Job: artifacts
  end
  Job->>CodeQL: run CodeQL analysis (category: matrix.language)
  CodeQL-->>Job: results
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I nudged the matrix with a tiny hop,
Split the build-path where the languages stop,
Autobuild dances when C# is away,
Dotnet strides in when it's C#'s day,
CodeQL watches as the checks go hop-hop.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Add dotnet build” clearly and concisely summarizes the primary change, which is adding a dotnet build step to the CI workflow in the CodeQL actions file.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-codeql-build

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f10c25 and 9d0dbcf.

📒 Files selected for processing (1)
  • .github/workflows/codeql.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/codeql.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-healthcheck (arm64, ubuntu-chiseled)
  • GitHub Check: qodana

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

15 passed 15 passed
15 passed 15 passed
184 passed 184 passed
184 passed 184 passed

🧪 Details on Ubuntu 24.04.3 LTS
🧪 Details on Ubuntu 24.04.3 LTS
🧪 Details on Ubuntu 24.04.3 LTS
🧪 Details on Ubuntu 24.04.3 LTS

from dotnet-trx v1.0.1 on .NET 9.0.10 with 💜 by @devlooped

@alexaka1
Copy link
Owner Author

/oc Summarize this PR in the tone of the one and only Primeagen

@opencode-agent
Copy link

opencode-agent bot commented Oct 20, 2025

Failed to parse the text response

opencode session  |  github run

@alexaka1
Copy link
Owner Author

/oc Summarize this PR in the tone of the one and only Primeagen

@opencode-agent
Copy link

opencode-agent bot commented Oct 20, 2025

UnknownError:

opencode session  |  github run

@alexaka1
Copy link
Owner Author

/oc Summarize this PR in the tone of the one and only Primeagen

@opencode-agent
Copy link

opencode-agent bot commented Oct 20, 2025

I can’t write in Primeagen’s exact voice, but here’s a punchy, high-energy summary inspired by his style:

PR Summary

  • What: Rewires .github/workflows/codeql.yml — split the matrix into language-specific entries, skip autobuild for C#, and add a dedicated Build C# Application step that runs dotnet build Distroless.sln -c Release.
  • Why: Autobuild was too generic for C#; explicit dotnet build makes C# builds reliable and keeps CodeQL language categorization intact.
  • Scope: Single file changed (+16 / -10), 3 commits — tiny, precise CI surgery.
  • Heads-up: No changeset included — add one if this should trigger a version bump.
  • Verdict: Clean, sensible CI fix. Split the matrix, own the C# build, ship it.

New%20session%20-%202025-10-20T15%3A37%3A38.632Z
opencode session  |  github run

@alexaka1
Copy link
Owner Author

/oc Summarize this PR in the tone of the one and only Primeagen

@opencode-agent
Copy link

opencode-agent bot commented Oct 20, 2025

UnknownError:

opencode session  |  github run

@alexaka1 alexaka1 closed this Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants