Ensure txn_participation is pruned corresponding with rows in txn. (#1685)

Author: gmalouf

.golangci.yml

@@ -12,10 +12,12 @@ linters:
   exclusions:
     generated: lax
     rules:
-      # revive: types is an acceptable package name in this codebase
+      # revive: types and util are acceptable package names in this codebase
       - linters:
           - revive
-        path: types/
+        paths:
+          - types/
+          - util/
         text: 'var-naming: avoid meaningless package names'
       # ignore govet false positive fixed in https://github.com/golang/go/issues/45043
       - path: (.+)\.go$

idb/postgres/postgres.go

@@ -2919,12 +2919,23 @@ func (db *IndexerDb) DeleteTransactions(ctx context.Context, keep uint64) error
 	// delete old transactions and update metastate
 	deleteTxns := func(tx pgx.Tx) error {
 		db.log.Infof("deleteTxns(): removing transactions before round %d", keep)
-		// delete query
+
+		// delete from txn
 		query := "DELETE FROM txn WHERE round < $1"
 		cmd, err2 := tx.Exec(ctx, query, keep)
 		if err2 != nil {
 			return fmt.Errorf("deleteTxns(): transaction delete err %w", err2)
 		}
+		db.log.Infof("%d transactions deleted", cmd.RowsAffected())
+
+		// delete from txn_participation
+		participationQuery := "DELETE FROM txn_participation WHERE round < $1"
+		participationCmd, err2 := tx.Exec(ctx, participationQuery, keep)
+		if err2 != nil {
+			return fmt.Errorf("deleteTxns(): txn_participation delete err %w", err2)
+		}
+		db.log.Infof("%d txn_participation records deleted", participationCmd.RowsAffected())
+
 		t := time.Now().UTC()
 		// update metastate
 		status := types.DeleteStatus{
@@ -2936,7 +2947,7 @@ func (db *IndexerDb) DeleteTransactions(ctx context.Context, keep uint64) error
 		if err2 != nil {
 			return fmt.Errorf("deleteTxns(): metastate update err %w", err2)
 		}
-		db.log.Infof("%d transactions deleted, last pruned at %s", cmd.RowsAffected(), status.LastPruned)
+		db.log.Infof("last pruned at %s", status.LastPruned)
 		return nil
 	}
 	err := db.txWithRetry(serializable, deleteTxns)

idb/postgres/postgres_integration_test.go

@@ -2206,6 +2206,17 @@ func TestDeleteTransactions(t *testing.T) {
 	err := db.DeleteTransactions(context.Background(), 2)
 	assert.NoError(t, err)
 
+	// verify txn_participation only has records for rounds >= 2
+	var minRound uint64
+	err = db.db.QueryRow(context.Background(), "SELECT MIN(round) FROM txn_participation").Scan(&minRound)
+	require.NoError(t, err)
+	assert.GreaterOrEqual(t, minRound, uint64(2), "txn_participation should only have records for rounds >= 2")
+
+	var participationRoundsLessThan2 int
+	err = db.db.QueryRow(context.Background(), "SELECT COUNT(*) FROM txn_participation WHERE round < 2").Scan(&participationRoundsLessThan2)
+	require.NoError(t, err)
+	assert.Equal(t, 0, participationRoundsLessThan2, "txn_participation should not have any records for round < 2")
+
 	// query txns
 	rowsCh, _ := db.Transactions(context.Background(), idb.TransactionFilter{})
 
@@ -2237,6 +2248,16 @@ func TestDeleteTransactions(t *testing.T) {
 	err = db.DeleteTransactions(context.Background(), 5)
 	assert.NoError(t, err)
 
+	// verify txn_participation only has records for rounds >= 5
+	err = db.db.QueryRow(context.Background(), "SELECT MIN(round) FROM txn_participation").Scan(&minRound)
+	require.NoError(t, err)
+	assert.GreaterOrEqual(t, minRound, uint64(5), "txn_participation should only have records for rounds >= 5")
+
+	var participationRoundsLessThan5 int
+	err = db.db.QueryRow(context.Background(), "SELECT COUNT(*) FROM txn_participation WHERE round < 5").Scan(&participationRoundsLessThan5)
+	require.NoError(t, err)
+	assert.Equal(t, 0, participationRoundsLessThan5, "txn_participation should not have any records for round < 5")
+
 	// 2 txns in round 5
 	rowsCh, _ = db.Transactions(context.Background(), idb.TransactionFilter{})
 	i = 0