Skip to content

Commit 500ae35

Browse files
committed
[docker] Fix build of Docker images for Ubuntu
1 parent e8f3470 commit 500ae35

File tree

3 files changed

+30
-9
lines changed

3 files changed

+30
-9
lines changed

docker/Dockerfile_ubuntu

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ ARG CUDA_VERSION
44
ARG UBUNTU_VERSION
55
FROM alicevision/alicevision-deps:${AV_DEPS_VERSION}-ubuntu${UBUNTU_VERSION}-cuda${CUDA_VERSION}
66
LABEL maintainer="AliceVision Team alicevision-team@googlegroups.com"
7+
ARG TARGET_ARCHITECTURE=core
78

89
# use CUDA_VERSION to select the image version to use
910
# see https://hub.docker.com/r/nvidia/cuda/
@@ -42,7 +43,7 @@ COPY docker ${AV_DEV}/docker
4243
RUN export CPU_CORES=`${AV_DEV}/docker/check-cpu.sh`; \
4344
cmake -DCMAKE_BUILD_TYPE=Release \
4445
-DBUILD_SHARED_LIBS:BOOL=ON \
45-
-DTARGET_ARCHITECTURE=core \
46+
-DTARGET_ARCHITECTURE=${TARGET_ARCHITECTURE} \
4647
-DALICEVISION_BUILD_DEPENDENCIES:BOOL=OFF \
4748
-DCMAKE_PREFIX_PATH:PATH="${AV_INSTALL}" \
4849
-DCMAKE_INSTALL_PREFIX:PATH="${AV_INSTALL}" \

docker/Dockerfile_ubuntu_deps

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,12 @@ RUN . ./etc/os-release && \
4141
nasm \
4242
automake \
4343
cmake \
44-
gfortran
44+
gfortran \
45+
clang-format \
46+
gcc-10 \
47+
g++-10 \
48+
cpp-10 && \
49+
update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10
4550

4651
ENV AV_DEV=/opt/AliceVision_git \
4752
AV_BUILD=/tmp/AliceVision_build \
@@ -69,6 +74,7 @@ WORKDIR "${AV_BUILD}"
6974
RUN cmake "${AV_DEV}" \
7075
-DCMAKE_BUILD_TYPE=Release \
7176
-DALICEVISION_BUILD_DEPENDENCIES:BOOL=ON \
77+
-DAV_BUILD_ZLIB:BOOL=ON \
7278
-DAV_BUILD_ALICEVISION:BOOL=OFF \
7379
-DCMAKE_INSTALL_PREFIX="${AV_INSTALL}"
7480

@@ -78,6 +84,8 @@ RUN mkdir -p "${AV_INSTALL}/lib" && \
7884

7985
RUN test -e /usr/local/cuda/lib64/libcublas.so || ln -s /usr/lib/x86_64-linux-gnu/libcublas.so /usr/local/cuda/lib64/libcublas.so
8086

87+
# RUN make -j ${CPU_CORES} onnxruntime
88+
# RUN make -j ${CPU_CORES} pcl
8189
# RUN make -j ${CPU_CORES} turbojpeg
8290
# RUN make -j ${CPU_CORES} boost
8391
# RUN make -j ${CPU_CORES} openexr
@@ -92,15 +100,14 @@ RUN test -e /usr/local/cuda/lib64/libcublas.so || ln -s /usr/lib/x86_64-linux-gn
92100
# RUN make -j ${CPU_CORES} tiff
93101
# RUN make -j ${CPU_CORES} png
94102
# RUN make -j ${CPU_CORES} libraw
95-
# RUN make -j ${CPU_CORES} boost
96103
# RUN make -j ${CPU_CORES} openimageio
97104
# RUN make -j ${CPU_CORES} alembic
98105
# RUN make -j ${CPU_CORES} ffmpeg
99106
# RUN make -j ${CPU_CORES} opencv
100107
# RUN make -j ${CPU_CORES} expat
101108

102-
# RUN make -j ${CPU_CORES} cctag
103109
# RUN make -j ${CPU_CORES} popsift
110+
# RUN make -j ${CPU_CORES} cctag
104111

105112
RUN cmake --build . -j ${CPU_CORES} && \
106113
mv "${AV_INSTALL}/bin" "${AV_INSTALL}/bin-deps" && \

docker/build-ubuntu.sh

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,39 +6,52 @@ test -e docker/fetch.sh || {
66
exit 1
77
}
88

9-
test -z "$AV_DEPS_VERSION" && AV_DEPS_VERSION=2023.10.12
9+
test -z "$AV_DEPS_VERSION" && AV_DEPS_VERSION=2023.12.13
1010
test -z "$AV_VERSION" && AV_VERSION="$(git rev-parse --abbrev-ref HEAD)-$(git rev-parse --short HEAD)"
1111
test -z "$CUDA_VERSION" && CUDA_VERSION=11.3.1
1212
test -z "$UBUNTU_VERSION" && UBUNTU_VERSION=20.04
1313
test -z "$REPO_OWNER" && REPO_OWNER=alicevision
1414
test -z "$DOCKER_REGISTRY" && DOCKER_REGISTRY=docker.io
1515

16+
echo "AV_VERSION: $AV_VERSION"
17+
echo "AV_DEPS_VERSION: $AV_DEPS_VERSION"
18+
echo "CUDA_VERSION: $CUDA_VERSION"
19+
echo "UBUNTU_VERSION: $UBUNTU_VERSION"
20+
21+
echo "--== FETCH DEPENDENCIES ==--"
22+
1623
./docker/fetch.sh
1724

18-
DEPS_DOCKER_TAG=${REPO_OWNER}/alicevision-deps:${AV_DEPS_VERSION}-centos${CENTOS_VERSION}-cuda${CUDA_VERSION}
25+
DEPS_DOCKER_TAG=${REPO_OWNER}/alicevision-deps:${AV_DEPS_VERSION}-ubuntu${UBUNTU_VERSION}-cuda${CUDA_VERSION}
26+
27+
echo "--== BUILD DEPENDENCIES ==--"
1928

2029
## DEPENDENCIES
2130
docker build \
2231
--rm \
2332
--build-arg CUDA_VERSION=${CUDA_VERSION} \
2433
--build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
25-
--tag alicevision/alicevision-deps:${AV_VERSION}-ubuntu${UBUNTU_VERSION}-cuda${CUDA_VERSION} \
34+
--tag ${DEPS_DOCKER_TAG} \
2635
-f docker/Dockerfile_ubuntu_deps .
2736

2837
echo ""
2938
echo " To upload results:"
3039
echo "docker push ${DEPS_DOCKER_TAG}"
3140
echo ""
3241

33-
DOCKER_TAG=${REPO_OWNER}/alicevision:${AV_VERSION}-centos${CENTOS_VERSION}-cuda${CUDA_VERSION}
42+
43+
DOCKER_TAG=${REPO_OWNER}/alicevision:${AV_VERSION}-ubuntu${UBUNTU_VERSION}-cuda${CUDA_VERSION}
44+
45+
echo "--== BUILD ALICEVISION ==--"
3446

3547
## ALICEVISION
3648
docker build \
3749
--rm \
3850
--build-arg CUDA_VERSION=${CUDA_VERSION} \
3951
--build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
52+
--build-arg AV_DEPS_VERSION=${AV_DEPS_VERSION} \
4053
--build-arg AV_VERSION=${AV_VERSION} \
41-
--tag alicevision/alicevision:${AV_VERSION}-ubuntu${UBUNTU_VERSION}-cuda${CUDA_VERSION} \
54+
--tag ${DOCKER_TAG} \
4255
-f docker/Dockerfile_ubuntu .
4356

4457
echo ""

0 commit comments

Comments
 (0)