Skip to content

Commit 6b5466a

Browse files
committed
fix(multiple): incorrect paths in declaration files for aria
A few places in the `@angular/aria` package were producing invalid paths when compiled for npm. We didn't catch them, because the Aria package wasn't running the same integration tests as the rest of the repo. These changes fix the issues by using explicit type annotations. Fixes #32665. (cherry picked from commit 3612ef6)
1 parent 5c5b0ed commit 6b5466a

File tree

10 files changed

+27
-24
lines changed

10 files changed

+27
-24
lines changed

goldens/aria/grid/index.api.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
55
```ts
66

7-
import * as _angular_aria_private_public_api from '@angular/aria/private/public-api';
87
import * as _angular_cdk_bidi from '@angular/cdk/bidi';
98
import * as _angular_core from '@angular/core';
109
import { ElementRef } from '@angular/core';
@@ -83,7 +82,7 @@ export class GridCellWidget {
8382
// @public
8483
export class GridRow {
8584
readonly element: HTMLElement;
86-
readonly _gridPattern: Signal<_angular_aria_private_public_api.GridPattern>;
85+
readonly _gridPattern: Signal<GridPattern>;
8786
readonly _pattern: GridRowPattern;
8887
readonly rowIndex: _angular_core.InputSignal<number | undefined>;
8988
// (undocumented)

goldens/aria/listbox/index.api.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
55
```ts
66

7-
import * as _angular_aria_private_public_api from '@angular/aria/private/public-api';
87
import * as _angular_cdk_bidi from '@angular/cdk/bidi';
98
import * as _angular_core from '@angular/core';
109

@@ -16,7 +15,7 @@ export class Listbox<V> {
1615
focusMode: _angular_core.InputSignal<"roving" | "activedescendant">;
1716
gotoFirst(): void;
1817
readonly id: _angular_core.InputSignal<string>;
19-
protected items: _angular_core.Signal<_angular_aria_private_public_api.OptionPattern<any>[]>;
18+
protected items: _angular_core.Signal<OptionPattern<V>[]>;
2019
multi: _angular_core.InputSignalWithTransform<boolean, unknown>;
2120
// (undocumented)
2221
_onFocus(): void;

goldens/aria/tabs/index.api.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
55
```ts
66

7-
import * as _angular_aria_private from '@angular/aria/private';
8-
import * as _angular_aria_private_public_api from '@angular/aria/private/public-api';
97
import * as _angular_cdk_bidi from '@angular/cdk/bidi';
108
import * as _angular_core from '@angular/core';
119
import { OnDestroy } from '@angular/core';
@@ -59,7 +57,7 @@ export class TabList implements OnInit, OnDestroy {
5957
readonly selectedTab: _angular_core.ModelSignal<string | undefined>;
6058
readonly selectionMode: _angular_core.InputSignal<"follow" | "explicit">;
6159
readonly softDisabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
62-
readonly _tabPatterns: _angular_core.Signal<_angular_aria_private_public_api.TabPattern[]>;
60+
readonly _tabPatterns: _angular_core.Signal<TabPattern[]>;
6361
readonly textDirection: _angular_core.WritableSignal<_angular_cdk_bidi.Direction>;
6462
// (undocumented)
6563
_unregister(child: Tab): void;
@@ -93,8 +91,8 @@ export class Tabs {
9391
readonly element: HTMLElement;
9492
// (undocumented)
9593
_register(child: TabList | TabPanel): void;
96-
readonly _tabPatterns: _angular_core.Signal<_angular_aria_private.TabPattern[] | undefined>;
97-
readonly _unorderedTabpanelPatterns: _angular_core.Signal<_angular_aria_private.TabPanelPattern[]>;
94+
readonly _tabPatterns: _angular_core.Signal<TabPattern[] | undefined>;
95+
readonly _unorderedTabpanelPatterns: _angular_core.Signal<TabPanelPattern[]>;
9896
// (undocumented)
9997
_unregister(child: TabList | TabPanel): void;
10098
// (undocumented)

goldens/aria/toolbar/index.api.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
55
```ts
66

7-
import * as _angular_aria_private_public_api from '@angular/aria/private/public-api';
87
import * as _angular_cdk_bidi from '@angular/cdk/bidi';
98
import * as _angular_core from '@angular/core';
109
import { OnDestroy } from '@angular/core';
@@ -15,7 +14,7 @@ export class Toolbar<V> {
1514
constructor();
1615
readonly disabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
1716
readonly element: HTMLElement;
18-
readonly _itemPatterns: _angular_core.Signal<_angular_aria_private_public_api.ToolbarWidgetPattern<V>[]>;
17+
readonly _itemPatterns: _angular_core.Signal<ToolbarWidgetPattern<V>[]>;
1918
// (undocumented)
2019
_onFocus(): void;
2120
readonly orientation: _angular_core.InputSignal<"vertical" | "horizontal">;
@@ -48,7 +47,7 @@ export class ToolbarWidget<V> implements OnInit, OnDestroy {
4847
ngOnInit(): void;
4948
readonly _pattern: ToolbarWidgetPattern<V>;
5049
readonly selected: () => boolean;
51-
readonly _toolbarPattern: _angular_core.Signal<_angular_aria_private_public_api.ToolbarPattern<V>>;
50+
readonly _toolbarPattern: _angular_core.Signal<ToolbarPattern<V>>;
5251
readonly value: _angular_core.InputSignal<V>;
5352
// (undocumented)
5453
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<ToolbarWidget<any>, "[ngToolbarWidget]", ["ngToolbarWidget"], { "id": { "alias": "id"; "required": false; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "value": { "alias": "value"; "required": true; "isSignal": true; }; }, {}, never, never, true, never>;

src/aria/grid/grid-row.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
input,
1616
Signal,
1717
} from '@angular/core';
18-
import {GridRowPattern} from '../private';
18+
import {GridPattern, GridRowPattern} from '../private';
1919
import {Grid} from './grid';
2020
import {GRID_CELL, GRID_ROW} from './grid-tokens';
2121

@@ -60,7 +60,7 @@ export class GridRow {
6060
private readonly _grid = inject(Grid);
6161

6262
/** The parent grid UI pattern. */
63-
readonly _gridPattern = computed(() => this._grid._pattern);
63+
readonly _gridPattern = computed<GridPattern>(() => this._grid._pattern);
6464

6565
/** The index of this row within the grid. */
6666
readonly rowIndex = input<number>();

src/aria/listbox/listbox.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
} from '@angular/core';
2222
import {Directionality} from '@angular/cdk/bidi';
2323
import {_IdGenerator} from '@angular/cdk/a11y';
24-
import {ComboboxListboxPattern, ListboxPattern} from '../private';
24+
import {ComboboxListboxPattern, ListboxPattern, OptionPattern} from '../private';
2525
import {ComboboxPopup} from '../combobox';
2626
import {Option} from './option';
2727
import {LISTBOX} from './tokens';
@@ -91,7 +91,9 @@ export class Listbox<V> {
9191
protected textDirection = inject(Directionality).valueSignal.asReadonly();
9292

9393
/** The Option UIPatterns of the child Options. */
94-
protected items = computed(() => this._options().map(option => option._pattern));
94+
protected items = computed<OptionPattern<V>[]>(() =>
95+
this._options().map(option => option._pattern),
96+
);
9597

9698
/** Whether the list is vertically or horizontally oriented. */
9799
orientation = input<'vertical' | 'horizontal'>('vertical');

src/aria/tabs/tab-list.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
OnInit,
2121
OnDestroy,
2222
} from '@angular/core';
23-
import {TabListPattern} from '../private';
23+
import {TabListPattern, TabPattern} from '../private';
2424
import {sortDirectives, TABS} from './utils';
2525
import type {Tab} from './tab';
2626

@@ -73,7 +73,7 @@ export class TabList implements OnInit, OnDestroy {
7373
readonly textDirection = inject(Directionality).valueSignal;
7474

7575
/** The Tab UIPatterns of the child Tabs. */
76-
readonly _tabPatterns = computed(() =>
76+
readonly _tabPatterns = computed<TabPattern[]>(() =>
7777
[...this._unorderedTabs()].sort(sortDirectives).map(tab => tab._pattern),
7878
);
7979

src/aria/tabs/tabs.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {computed, Directive, ElementRef, inject, signal} from '@angular/core';
1010
import {TabList} from './tab-list';
1111
import {TabPanel} from './tab-panel';
1212
import {TABS} from './utils';
13+
import {TabPanelPattern, TabPattern} from '../private';
1314

1415
/**
1516
* A Tabs container.
@@ -61,10 +62,10 @@ export class Tabs {
6162
private readonly _unorderedPanels = signal(new Set<TabPanel>());
6263

6364
/** The Tab UIPattern of the child Tabs. */
64-
readonly _tabPatterns = computed(() => this._tablist()?._tabPatterns());
65+
readonly _tabPatterns = computed<TabPattern[] | undefined>(() => this._tablist()?._tabPatterns());
6566

6667
/** The TabPanel UIPattern of the child TabPanels. */
67-
readonly _unorderedTabpanelPatterns = computed(() =>
68+
readonly _unorderedTabpanelPatterns = computed<TabPanelPattern[]>(() =>
6869
[...this._unorderedPanels()].map(tabpanel => tabpanel._pattern),
6970
);
7071

src/aria/toolbar/toolbar-widget.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@ import {
1616
OnInit,
1717
OnDestroy,
1818
} from '@angular/core';
19-
import {ToolbarWidgetPattern, ToolbarWidgetGroupPattern, SignalLike} from '../private';
19+
import {
20+
ToolbarWidgetPattern,
21+
ToolbarWidgetGroupPattern,
22+
SignalLike,
23+
ToolbarPattern,
24+
} from '../private';
2025
import {_IdGenerator} from '@angular/cdk/a11y';
2126
import {Toolbar} from './toolbar';
2227
import {TOOLBAR_WIDGET_GROUP} from './utils';
@@ -65,7 +70,7 @@ export class ToolbarWidget<V> implements OnInit, OnDestroy {
6570
readonly id = input(inject(_IdGenerator).getId('ng-toolbar-widget-', true));
6671

6772
/** The parent Toolbar UIPattern. */
68-
readonly _toolbarPattern = computed(() => this._toolbar._pattern);
73+
readonly _toolbarPattern = computed<ToolbarPattern<V>>(() => this._toolbar._pattern);
6974

7075
/** Whether the widget is disabled. */
7176
readonly disabled = input(false, {transform: booleanAttribute});

src/aria/toolbar/toolbar.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
signal,
1818
model,
1919
} from '@angular/core';
20-
import {ToolbarPattern} from '../private';
20+
import {ToolbarPattern, ToolbarWidgetPattern} from '../private';
2121
import {Directionality} from '@angular/cdk/bidi';
2222
import type {ToolbarWidget} from './toolbar-widget';
2323
import {sortDirectives} from './utils';
@@ -72,7 +72,7 @@ export class Toolbar<V> {
7272
readonly textDirection = inject(Directionality).valueSignal;
7373

7474
/** Sorted UIPatterns of the child widgets */
75-
readonly _itemPatterns = computed(() =>
75+
readonly _itemPatterns = computed<ToolbarWidgetPattern<V>[]>(() =>
7676
[...this._widgets()].sort(sortDirectives).map(widget => widget._pattern),
7777
);
7878

0 commit comments

Comments
 (0)