Skip to content

Commit 790accd

Browse files
authored
fix(aria/menu): expand selector for trigger (#32617)
Allows non-button elements to be set as menu triggers since users might be applying it to custom components. Fixes #32616.
1 parent 3b8f7f3 commit 790accd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

goldens/aria/menu/index.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class MenuTrigger<V> {
9999
readonly softDisabled: _angular_core.InputSignalWithTransform<boolean, unknown>;
100100
readonly textDirection: _angular_core.WritableSignal<_angular_cdk_bidi.Direction>;
101101
// (undocumented)
102-
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<MenuTrigger<any>, "button[ngMenuTrigger]", ["ngMenuTrigger"], { "menu": { "alias": "menu"; "required": false; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "softDisabled": { "alias": "softDisabled"; "required": false; "isSignal": true; }; }, {}, never, never, true, never>;
102+
static ɵdir: _angular_core.ɵɵDirectiveDeclaration<MenuTrigger<any>, "[ngMenuTrigger]", ["ngMenuTrigger"], { "menu": { "alias": "menu"; "required": false; "isSignal": true; }; "disabled": { "alias": "disabled"; "required": false; "isSignal": true; }; "softDisabled": { "alias": "softDisabled"; "required": false; "isSignal": true; }; }, {}, never, never, true, never>;
103103
// (undocumented)
104104
static ɵfac: _angular_core.ɵɵFactoryDeclaration<MenuTrigger<any>, never>;
105105
}

src/aria/menu/menu-trigger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import type {Menu} from './menu';
4141
* @see [MenuBar](guide/aria/menubar)
4242
*/
4343
@Directive({
44-
selector: 'button[ngMenuTrigger]',
44+
selector: '[ngMenuTrigger]',
4545
exportAs: 'ngMenuTrigger',
4646
host: {
4747
'[attr.tabindex]': '_pattern.tabIndex()',

0 commit comments

Comments
 (0)