refactor(httpapi): avoid redundant sync decodes

Author: kitlangton

packages/opencode/src/server/routes/instance/httpapi/mcp.ts

@@ -139,9 +139,10 @@ export const mcpHandlers = Layer.unwrap(
     })
 
     const add = Effect.fn("McpHttpApi.add")(function* (ctx: { payload: typeof AddPayload.Type }) {
-      const payload = Schema.decodeUnknownSync(AddPayload)(ctx.payload)
-      const result = (yield* mcp.add(payload.name, payload.config)).status
-      return Schema.decodeUnknownSync(StatusMap)("status" in result ? { [payload.name]: result } : result)
+      const result = (yield* mcp.add(ctx.payload.name, ctx.payload.config)).status
+      return yield* Schema.decodeUnknownEffect(StatusMap)("status" in result ? { [ctx.payload.name]: result } : result).pipe(
+        Effect.mapError(() => new HttpApiError.BadRequest({})),
+      )
     })
 
     const authStart = Effect.fn("McpHttpApi.authStart")(function* (ctx: { params: { name: string } }) {

packages/opencode/src/server/routes/instance/httpapi/sync.ts

@@ -96,8 +96,7 @@ export const syncHandlers = Layer.unwrap(
     })
 
     const replay = Effect.fn("SyncHttpApi.replay")(function* (ctx: { payload: typeof ReplayPayload.Type }) {
-      const payload = Schema.decodeUnknownSync(ReplayPayload)(ctx.payload)
-      const events: SyncEvent.SerializedEvent[] = payload.events.map((event) => ({
+      const events: SyncEvent.SerializedEvent[] = ctx.payload.events.map((event) => ({
         id: event.id,
         aggregateID: event.aggregateID,
         seq: event.seq,

packages/opencode/src/server/routes/instance/httpapi/workspace.ts

@@ -123,7 +123,7 @@ export const workspaceHandlers = Layer.unwrap(
       return yield* Effect.promise(() =>
         Instance.restore(instance, () =>
           Workspace.create({
-            ...Schema.decodeUnknownSync(CreatePayload)(ctx.payload),
+            ...ctx.payload,
             projectID: instance.project.id,
           }),
         ),