Update following code review

Author: pierrejeambrun

airflow-core/docs/administration-and-deployment/plugins.rst

@@ -206,7 +206,7 @@ definitions in Airflow.
         # Optional icon, url to an svg file.
         "icon": "https://example.com/icon.svg",
         # Optional dark icon for the dark theme, url to an svg file. If not provided, "icon" will be used for both light and dark themes.
-        "dark_mode_icon": "https://example.com/dark_icon.svg",
+        "icon_dark_mode": "https://example.com/dark_icon.svg",
         # Optional parameters, relative URL location for the iframe rendering. If not provided, external view will be rendeded as an external link. Should
         # not contain a leading slash.
         "url_route": "my_iframe_view",

airflow-core/src/airflow/api_fastapi/core_api/datamodels/plugins.py

@@ -77,7 +77,7 @@ class ExternalViewResponse(BaseModel):
     name: str
     href: str
     icon: str | None = None
-    dark_mode_icon: str | None = None
+    icon_dark_mode: str | None = None
     url_route: str | None = None
     category: str | None = None
     destination: Literal["nav", "dag", "dag_run", "task", "task_instance"] = "nav"

airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml

@@ -9305,11 +9305,11 @@ components:
           - type: string
           - type: 'null'
           title: Icon
-        dark_mode_icon:
+        icon_dark_mode:
           anyOf:
           - type: string
           - type: 'null'
-          title: Dark Mode Icon
+          title: Icon Dark Mode
         url_route:
           anyOf:
           - type: string

airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts

@@ -3283,7 +3283,7 @@ export const $ExternalViewResponse = {
             ],
             title: 'Icon'
         },
-        dark_mode_icon: {
+        icon_dark_mode: {
             anyOf: [
                 {
                     type: 'string'
@@ -3292,7 +3292,7 @@ export const $ExternalViewResponse = {
                     type: 'null'
                 }
             ],
-            title: 'Dark Mode Icon'
+            title: 'Icon Dark Mode'
         },
         url_route: {
             anyOf: [

airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts

@@ -878,7 +878,7 @@ export type ExternalViewResponse = {
     name: string;
     href: string;
     icon?: string | null;
-    dark_mode_icon?: string | null;
+    icon_dark_mode?: string | null;
     url_route?: string | null;
     category?: string | null;
     destination?: 'nav' | 'dag' | 'dag_run' | 'task' | 'task_instance';

airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx

@@ -44,8 +44,15 @@ export const PluginMenuItem = ({ href, icon, name, topLevel = false, url_route:
         to={href}
       />
     ) : (
-      <Box alignItems="center" display="flex" gap={2} outline="none" px={2}>
-        <Link aria-label={name} href={href} rel="noopener noreferrer" target="_blank" width="100%">
+      <Box alignItems="center" display="flex" gap={2} outline="none" px={2} py="6px">
+        <Link
+          aria-label={name}
+          fontSize="sm"
+          href={href}
+          rel="noopener noreferrer"
+          target="_blank"
+          width="100%"
+        >
           {name}
         </Link>
       </Box>
@@ -72,7 +79,7 @@ export const PluginMenuItem = ({ href, icon, name, topLevel = false, url_route:
 
   return (
     <RouterLink to={`plugin/${urlRoute}`}>
-      <Box alignItems="center" display="flex" gap={2} px={2}>
+      <Box alignItems="center" display="flex" fontSize="sm" gap={2} px={2} py="6px">
         {typeof icon === "string" ? (
           <Image height="1.25rem" src={icon} width="1.25rem" />
         ) : (

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py

@@ -77,30 +77,30 @@ def test_external_views_model_validator(self, test_client):
         assert test_plugin["external_views"] == [
             # external_views
             {
-                "name": "Test IFrame Plugin",
-                "href": "https://www.google.com",
-                "icon": "https://example.com/icon.svg",
-                "dark_mode_icon": "https://example.com/dark_icon.svg",
+                "name": "Test IFrame Airflow Docs",
+                "href": "https://airflow.apache.org/",
+                "icon": "https://raw.githubusercontent.com/lucide-icons/lucide/refs/heads/main/icons/plug.svg",
+                "icon_dark_mode": None,
                 "url_route": "test_iframe_plugin",
                 "destination": "nav",
                 "category": "browse",
             },
             # appbuilder_menu_items
             {
                 "category": "Search",
-                "dark_mode_icon": None,
                 "destination": "nav",
                 "href": "https://www.google.com",
                 "icon": None,
+                "icon_dark_mode": None,
                 "name": "Google",
                 "url_route": None,
             },
             {
                 "category": None,
-                "dark_mode_icon": None,
                 "destination": "nav",
                 "href": "https://www.apache.org/",
                 "icon": None,
+                "icon_dark_mode": None,
                 "label": "The Apache Software Foundation",
                 "name": "apache",
                 "url_route": None,

airflow-core/tests/unit/cli/commands/test_plugins_command.py

@@ -93,10 +93,9 @@ def test_should_display_one_plugin(self):
                 "external_views": [
                     {
                         "destination": "nav",
-                        "icon": "https://example.com/icon.svg",
-                        "dark_mode_icon": "https://example.com/dark_icon.svg",
-                        "name": "Test IFrame Plugin",
-                        "href": "https://www.google.com",
+                        "icon": "https://raw.githubusercontent.com/lucide-icons/lucide/refs/heads/main/icons/plug.svg",
+                        "name": "Test IFrame Airflow Docs",
+                        "href": "https://airflow.apache.org/",
                         "url_route": "test_iframe_plugin",
                         "category": "browse",
                     },

airflow-core/tests/unit/plugins/test_plugin.py

@@ -103,10 +103,9 @@ async def dispatch(self, request, call_next):
 }
 
 external_view_with_metadata = {
-    "name": "Test IFrame Plugin",
-    "href": "https://www.google.com",
-    "icon": "https://example.com/icon.svg",
-    "dark_mode_icon": "https://example.com/dark_icon.svg",
+    "name": "Test IFrame Airflow Docs",
+    "href": "https://airflow.apache.org/",
+    "icon": "https://raw.githubusercontent.com/lucide-icons/lucide/refs/heads/main/icons/plug.svg",
     "url_route": "test_iframe_plugin",
     "destination": "nav",
     "category": "browse",

airflow-ctl/src/airflowctl/api/datamodels/generated.py

@@ -533,7 +533,7 @@ class ExternalViewResponse(BaseModel):
     name: Annotated[str, Field(title="Name")]
     href: Annotated[str, Field(title="Href")]
     icon: Annotated[str | None, Field(title="Icon")] = None
-    dark_mode_icon: Annotated[str | None, Field(title="Dark Mode Icon")] = None
+    icon_dark_mode: Annotated[str | None, Field(title="Icon Dark Mode")] = None
     url_route: Annotated[str | None, Field(title="Url Route")] = None
     category: Annotated[str | None, Field(title="Category")] = None
     destination: Annotated[Destination | None, Field(title="Destination")] = "nav"