fix(chart): Add pdbs for triggerer and workers

Author: mrrsm

chart/templates/workers/worker-poddisruptionbudget.yaml

@@ -20,7 +20,6 @@
 ################################
 ## Airflow Worker PodDisruptionBudget
 #################################
-{{- if .Values.workers.enabled }}
 {{- if .Values.workers.podDisruptionBudget.enabled }}
 apiVersion: policy/v1
 kind: PodDisruptionBudget
@@ -43,4 +42,3 @@ spec:
       release: {{ .Release.Name }}
   {{- toYaml .Values.workers.podDisruptionBudget.config | nindent 2 }}
 {{- end }}
-{{- end }}

helm-tests/tests/helm_tests/airflow_core/test_pdb_triggerer.py

@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+from chart_utils.helm_template_generator import render_chart
+
+
+class TestTriggererPdb:
+    """Tests Triggerer PDB."""
+
+    def test_should_pass_validation_with_just_pdb_enabled_v1(self):
+        render_chart(
+            values={"triggerer": {"podDisruptionBudget": {"enabled": True}}},
+            show_only=["templates/triggerer/triggerer-poddisruptionbudget.yaml"],
+        )  # checks that no validation exception is raised
+
+    def test_should_pass_validation_with_just_pdb_enabled_v1beta1(self):
+        render_chart(
+            values={"triggerer": {"podDisruptionBudget": {"enabled": True}}},
+            show_only=["templates/triggerer/triggerer-poddisruptionbudget.yaml"],
+            kubernetes_version="1.16.0",
+        )  # checks that no validation exception is raised
+
+    def test_should_add_component_specific_labels(self):
+        docs = render_chart(
+            values={
+                "triggerer": {
+                    "podDisruptionBudget": {"enabled": True},
+                    "labels": {"test_label": "test_label_value"},
+                },
+            },
+            show_only=["templates/triggerer/triggerer-poddisruptionbudget.yaml"],
+        )
+
+        assert "test_label" in jmespath.search("metadata.labels", docs[0])
+        assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
+
+    def test_should_pass_validation_with_pdb_enabled_and_min_available_param(self):
+        render_chart(
+            values={
+                "triggerer": {
+                    "podDisruptionBudget": {
+                        "enabled": True,
+                        "config": {"maxUnavailable": None, "minAvailable": 1},
+                    }
+                }
+            },
+            show_only=["templates/triggerer/triggerer-poddisruptionbudget.yaml"],
+        )  # checks that no validation exception is raised

helm-tests/tests/helm_tests/airflow_core/test_pdb_worker.py

@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+from chart_utils.helm_template_generator import render_chart
+
+
+class TestWorkerPdb:
+    """Tests Worker PDB."""
+
+    def test_should_pass_validation_with_just_pdb_enabled_v1(self):
+        render_chart(
+            values={"workers": {"podDisruptionBudget": {"enabled": True}}},
+            show_only=["templates/workers/worker-poddisruptionbudget.yaml"],
+        )  # checks that no validation exception is raised
+
+    def test_should_pass_validation_with_just_pdb_enabled_v1beta1(self):
+        render_chart(
+            values={"workers": {"podDisruptionBudget": {"enabled": True}}},
+            show_only=["templates/workers/worker-poddisruptionbudget.yaml"],
+            kubernetes_version="1.16.0",
+        )  # checks that no validation exception is raised
+
+    def test_should_add_component_specific_labels(self):
+        docs = render_chart(
+            values={
+                "workers": {
+                    "podDisruptionBudget": {"enabled": True},
+                    "labels": {"test_label": "test_label_value"},
+                },
+            },
+            show_only=["templates/workers/worker-poddisruptionbudget.yaml"],
+        )
+
+        assert "test_label" in jmespath.search("metadata.labels", docs[0])
+        assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
+
+    def test_should_pass_validation_with_pdb_enabled_and_min_available_param(self):
+        render_chart(
+            values={
+                "workers": {
+                    "podDisruptionBudget": {
+                        "enabled": True,
+                        "config": {"maxUnavailable": None, "minAvailable": 1},
+                    },
+                }
+            },
+            show_only=["templates/workers/worker-poddisruptionbudget.yaml"],
+        )  # checks that no validation exception is raised