fix(release): fix svn add command and add script to generate release notes #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jan 14, 2025
dev/release/post-website.sh
Outdated
Comment on lines
51
to
55
| if [ ${previous_major_version} -eq ${major_version} ]; then | ||
| release_type=patch | ||
| else | ||
| release_type=major | ||
| fi |
Member
There was a problem hiding this comment.
Can we add "minor" release detection?
dev/release/post-website.sh
Outdated
|
|
||
| pushd "${ARROW_SITE_DIR}" | ||
| DEFAULT_BRANCH="$(git rev-parse --abbrev-ref origin/HEAD | sed s@origin/@@)" | ||
| git fetch --all --prune --tags --force -j$(nproc) |
Member
There was a problem hiding this comment.
Could you add a check whether this working copy is a fork not apache/arrow-site?
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Ease of utility for release process
What changes are included in this PR?
Fixing
svn addcommand to explicitly refer to the directory so it doesn't present an error anymore.Add script to generate the markdown page for adding release notes to the arrow-site repo.