feat(parquet/file): Add SeekToRow for Column readers #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Addressing the comments in #278 (comment) to allow for optimizing reads by skipping entire pages and leveraging the offset index if it exists.
What changes are included in this PR?
Deprecating the old
NewColumnChunkReaderandNewPageReadermethods as they really aren't safe to use outside of the package, and have proved difficult to evolve without breaking changes. Instead users should rely on using theRowGroupReaderto perform the creation of the column readers and page readers, which is generally what is done by consumers already.Adding
SeekToRowmethod on the ColumnChunkReader to allow skipping to a particular row in the column chunk (which also allows quickly resetting back to the beginning of a column!) along withSeekToPageWithRowmethod on the page reader. Also updates theSkipmethod to properly skip rows in a repeated column, not just values.Are these changes tested?
Yes, tests are included.
Are there any user-facing changes?
Just the new methods. The deprecated methods are not removed currently.