fix(gauge): render gauge sectors in the order of the "clockwise" option#17691
Merged
Ovilia merged 3 commits intoapache:masterfrom Sep 28, 2022
Merged
fix(gauge): render gauge sectors in the order of the "clockwise" option#17691Ovilia merged 3 commits intoapache:masterfrom
Ovilia merged 3 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
Ovilia
requested changes
Sep 26, 2022
Contributor
Ovilia
left a comment
Ovilia
left a comment
There was a problem hiding this comment.
Thanks for your contribution! It looks good to me except one small detail.
src/chart/gauge/GaugeView.ts
Outdated
| } | ||
|
|
||
| sectors.reverse(); | ||
| sectors.forEach(sector => group.add(sector)); |
Contributor
There was a problem hiding this comment.
Please use each from 'zrender/src/core/util' instead of forEach.
Closed
Ovilia
approved these changes
Sep 28, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
add gauge sectors in the order of the "clockwise" option
Fixed issues
#17633
Details
Before: What was the problem?
The gauge view adds sectors in the order of the
colorListoption, however, these elements will be covered by elements added later, and the order of the sectors looks reversed when theroundCapoption is enabled.After: How does it behave after the fixing?
Reverse the sectors array before adding them to the graphic group
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
gauge-case
Others
Merging options
Other information