fix: EChartsInitOpts type error about height and width. close #17667#17727
Merged
Ovilia merged 1 commit intoapache:masterfrom Oct 8, 2022
YuShengHou:master
Merged
fix: EChartsInitOpts type error about height and width. close #17667#17727Ovilia merged 1 commit intoapache:masterfrom YuShengHou:master
Ovilia merged 1 commit intoapache:masterfrom
YuShengHou:master
Conversation
echarts-bot
bot
added
PR: awaiting review
PR: doc unchanged
PR: first-time contributor
labels
|
Thanks for your contribution! |
YuShengHou
changed the title
Ovilia
approved these changes
Oct 8, 2022
Contributor
Ovilia
left a comment
Ovilia
left a comment
There was a problem hiding this comment.
According to the definition in ZRender, this change should be correct.
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix type error about
heightandwidthofEChartsInitOptsFixed issues
#17667
Details
Before: What was the problem?
[Bug] The documentation for EChartsInitOpts has a type error about height and width
The description type of the document differs from that in the code
After: How does it behave after the fixing?
Add union types
number | stringforheightandwidthDocument Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information