Skip to content

Commit 683e657

Browse files
committed
Adds some extra comments
To clarify / provide more color to the documentation.
1 parent b3b33a3 commit 683e657

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

ui/sdk/src/hamilton_sdk/driver.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ def _hash_module(
5858
)
5959

6060
def safe_getmembers(module):
61-
"""Need this because some modules are lazily loaded and we can't get the members."""
61+
"""Need this because some modules are lazily loaded and we can't get the members.
62+
e.g. ibis.
63+
"""
6264
try:
6365
return inspect.getmembers(module)
6466
except Exception as e:

ui/sdk/src/hamilton_sdk/tracking/ibis_stats.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def base_data_type_mapping(data_type: core.DataType) -> str:
3030

3131

3232
base_schema = {
33-
# we can't get all of these about a pyspark dataframe
33+
# we can't get all of these about an ibis dataframe
3434
"base_data_type": None,
3535
# 'count': 0,
3636
"data_type": None,

0 commit comments

Comments
 (0)