Skip to content

Commit 7e052f5

Browse files
committed
Address review comments
1 parent 8d86da1 commit 7e052f5

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

hudi-sync/hudi-adb-sync/src/main/java/org/apache/hudi/sync/adb/AdbSyncTool.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public class AdbSyncTool extends AbstractSyncTool {
6565
private final AbstractAdbSyncHoodieClient hoodieAdbClient;
6666
private final String snapshotTableName;
6767
private final Option<String> roTableTableName;
68-
private static final byte[] LOCK = new byte[1];
6968

7069
public AdbSyncTool(TypedProperties props, Configuration conf, FileSystem fs) {
7170
super(props, conf, fs);
@@ -93,10 +92,6 @@ private AbstractAdbSyncHoodieClient getHoodieAdbClient(AdbSyncConfig adbSyncConf
9392

9493
@Override
9594
public void syncHoodieTable() {
96-
syncHoodieTable(true);
97-
}
98-
99-
public void syncHoodieTable(boolean closeClient) {
10095
try {
10196
switch (hoodieAdbClient.getTableType()) {
10297
case COPY_ON_WRITE:
@@ -117,9 +112,7 @@ public void syncHoodieTable(boolean closeClient) {
117112
} catch (Exception re) {
118113
throw new HoodieAdbSyncException("Sync hoodie table to ADB failed, tableName:" + adbSyncConfig.tableName, re);
119114
} finally {
120-
if (closeClient) {
121-
hoodieAdbClient.close();
122-
}
115+
hoodieAdbClient.close();
123116
}
124117
}
125118

@@ -130,7 +123,7 @@ private void syncHoodieTable(String tableName, boolean useRealtimeInputFormat,
130123

131124
if (adbSyncConfig.autoCreateDatabase) {
132125
try {
133-
synchronized (LOCK) {
126+
synchronized (AdbSyncTool.class) {
134127
if (!hoodieAdbClient.databaseExists(adbSyncConfig.databaseName)) {
135128
hoodieAdbClient.createDatabase(adbSyncConfig.databaseName);
136129
}

0 commit comments

Comments
 (0)